Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iv26g-0005TP-Pm for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Jan 2020 16:46:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iv26f-0000jI-E2 for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Jan 2020 16:46:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iv26f-0000iy-2A for pgsql-hackers@lists.postgresql.org; Fri, 24 Jan 2020 16:46:53 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iv26c-0007YG-UH for pgsql-hackers@lists.postgresql.org; Fri, 24 Jan 2020 16:46:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 00OGkmdV000965; Fri, 24 Jan 2020 11:46:48 -0500 From: Tom Lane To: Peter Eisentraut cc: Alvaro Herrera , =?UTF-8?Q?Juan_Jos=c3=a9_Santamar=c3=ada_Flecha?= , Arthur Zakirov , Tomas Vondra , PostgreSQL Hackers Subject: Re: Allow to_date() and to_timestamp() to accept localized names In-reply-to: <2f83150e-a2c0-6318-3125-d9b86e421aa2@2ndquadrant.com> References: <20200124161814.GA8989@alvherre.pgsql> <32487.1579882979@sss.pgh.pa.us> <2f83150e-a2c0-6318-3125-d9b86e421aa2@2ndquadrant.com> Comments: In-reply-to Peter Eisentraut message dated "Fri, 24 Jan 2020 17:42:31 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <957.1579884408.1@sss.pgh.pa.us> Date: Fri, 24 Jan 2020 11:46:48 -0500 Message-ID: <964.1579884408@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Eisentraut writes: > Looking through the patch quickly, if you want to get Unicode-fancy, > doing a case-insensitive comparison by running lower-case on both > strings is also wrong in corner cases. All the Greek month names end in > sigma, so I suspect that this patch might not work correctly in such cases. Hm. That's basically what citext does, and I don't recall hearing complaints about that. What other definition of "case insensitive" would you suggest? regards, tom lane