From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
cc: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Japin Li <japinli@hotmail.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        Laurenz Albe <laurenz.albe@cybertec.at>,
        "smithpb2250@gmail.com" <smithpb2250@gmail.com>,
        "david.zhang@highgo.ca" <david.zhang@highgo.ca>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Support tab completion for upper character inputs in psql
In-reply-to: <87wniezq0u.fsf@wibble.ilmari.org>
References: 
 <OS0PR01MB611303B647967B6949B759F1FB4E9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <80b093ae-88bd-8d8a-68b9-b535a3ab11be@enterprisedb.com>
 <OS0PR01MB61137C7B2B09C0431415B9DBFBD69@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <54bd7839-f463-ef03-f2d2-ccb8184b9b27@enterprisedb.com>
 <1068530.1641480996@sss.pgh.pa.us>
 <TYCPR01MB6128BD8EA1529F4270114C18FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com>
 <MEYP282MB1669EAF2183E67EAF86F7F61B64D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
 <TYCPR01MB6128D4933189A74AAD326F98FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com>
 <3547066.1642272686@sss.pgh.pa.us>
 <OS0PR01MB6113C130461FB8A9DBA0DAEBFB5A9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <OS0PR01MB6113DB08D8CEA4E214DA37BBFB5F9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <2304294.1643152287@sss.pgh.pa.us>
 <OS0PR01MB611360D58EA41FC6557D92C0FB229@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <2771362.1643385796@sss.pgh.pa.us> <2805502.1643405157@sss.pgh.pa.us>
 <2818574.1643408192@sss.pgh.pa.us> <OS0PR01!
 MB61130E73CFDB2C0E8FD1A892FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <324281.1643567679@sss.pgh.pa.us> <8735l41ynm.fsf@wibble.ilmari.org>
 <534641.1643594097@sss.pgh.pa.us> <838381.1643665141@sss.pgh.pa.us>
 <87wniezq0u.fsf@wibble.ilmari.org>
Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?=
 <ilmari@ilmari.org>
	message dated "Tue, 01 Feb 2022 13:15:45 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <964539.1643753218.1@sss.pgh.pa.us>
Date: Tue, 01 Feb 2022 17:06:58 -0500
Message-ID: <964540.1643753218@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/964540.1643753218%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>>> We could do something hacky like matching case only when there's
>>> no longer any matching object names, but that might be too magic.
>> I experimented with that, and it actually doesn't seem as weird
>> as I feared.  See if you like this ...

> That's a reasonable compromise, and the implementation is indeed less
> hacky than one might have feared.  Although I think putting the
> `num_keywords` variable before `num_other` would read better.

Hm... I renamed "num_other" to "num_query_other" instead.

> Going through the uses of COMPLETE_WITH(_SCHEMA)_QUERY_PLUS, I noticed a
> few that had the keywords in lower case, which is fixed in the attached
> patch (except the hardcoded data types, which aren't really keywords).

Yeah, my oversight.  Pushed.

			regards, tom lane