From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Smith <smithpb2250@gmail.com>
cc: Zheng Li <zhengli10@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: pub/sub - specifying optional parameters without values.
In-reply-to: <CAHut+Puy_mtvO7Zwb6PaRZyUYZ4yR1M2bMaqg_aorMHbrTbcWA@mail.gmail.com>
References: <CAHut+PvwjZfdGt2R8HTXgSZft=jZKymrS8KUg31pS7zqaaWKKw@mail.gmail.com> <CAHut+Pt_GEKrRQuqKKJu6v1g61_BEGKx8TNuhYN_euDmZwqRfA@mail.gmail.com> <167328582545.1136.8620247763467087383.pgcf@coridan.postgresql.org> <359467.1675028199@sss.pgh.pa.us> <CAHut+PuaFu77FtxD-fMoL60O2e8=Zs7XWHGGT1q0+3LDK=eJJg@mail.gmail.com> <501328.1675098031@sss.pgh.pa.us> <CAHut+Puy_mtvO7Zwb6PaRZyUYZ4yR1M2bMaqg_aorMHbrTbcWA@mail.gmail.com>
Comments: In-reply-to Peter Smith <smithpb2250@gmail.com>
	message dated "Tue, 31 Jan 2023 09:36:53 +1100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <966587.1675119343.1@sss.pgh.pa.us>
Date: Mon, 30 Jan 2023 17:55:43 -0500
Message-ID: <966588.1675119343@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/966588.1675119343%40sss.pgh.pa.us>
Precedence: bulk

Peter Smith <smithpb2250@gmail.com> writes:
> I'd forgotten about the 'streaming' option -- AFAIK this was
> previously a boolean parameter and so its [= value] part can also be
> omitted. However, in PG16 streaming became an enum type
> (on/off/parallel), and the value can still be omitted but that is not
> really being covered by the new generic text note about booleans added
> by yesterday's patch.

Hmph.  I generally think that options defined like this (it's a boolean,
except it isn't) are a bad idea, and would prefer to see that API
rethought while we still can.

			regards, tom lane