Message-ID: <9682e829-4120-a3d5-4834-d909ad4b49d8@gmail.com>
Date: Mon, 10 Jul 2023 07:05:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: Autogenerate some wait events code and documentation
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <ZKJxZrnFTxoCx8a5@paquier.xyz> <ZKJ0tzXSH1LyqI9V@paquier.xyz>
 <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com>
 <ZKTN//NfDeP1egLW@paquier.xyz>
 <20230705215939.ulnfbr4zavb2x7ri@awork3.anarazel.de>
 <ZKYMfGRK1PIlGiBB@paquier.xyz>
 <20230707011943.qxbj3vj2iwsfgqvq@awork3.anarazel.de>
 <ZKeZVPEBkBxYs1FY@paquier.xyz> <ZKo4b1bDI5+FoTex@paquier.xyz>
 <1f74adab-5ed8-450a-853a-f0b4bfe0e751@gmail.com>
 <ZKpjawSAHIjYV2+Q@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZKpjawSAHIjYV2+Q@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/9682e829-4120-a3d5-4834-d909ad4b49d8%40gmail.com>
Precedence: bulk

Hi,

On 7/9/23 9:36 AM, Michael Paquier wrote:
> On Sun, Jul 09, 2023 at 09:15:34AM +0200, Drouvot, Bertrand wrote:
>> I also noticed that you now provide the culprit line in case of parsing
>> failure (thanks for that).
> 
> Yes, that's mentioned in the commit message I quickly wrote in 0002.
> 
>>   #
>> -#   "C symbol in enums" "format in the system views" "description in the docs"
>> +#   "format in the system views" "description in the docs"
>>
>> Should we add a note here about the impact of the "format in the system views" on
>> the auto generated enum? (aka how it is generated based on its format)?
> 
> There is one, 

Yeah there is one in generate-wait_event_types.pl. I was wondering
to add one in wait_event_names.txt too (as this is the place where
no wait events would be added if any).

> but now that I look at it WAIT_EVENT repeated twice does
> not look great, so this could use "FooBarName" or equivalent:

+1 for "FooBarName"

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com