Feedback-ID: i131946ab:Fastmail
Message-ID: <96832c09-db85-8443-c654-dae928816830@enterprisedb.com>
Date: Mon, 13 Mar 2023 07:39:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: CI and test improvements
Content-Language: en-US
To: Justin Pryzby <pryzby@telsasoft.com>,
 Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
 Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org,
 Noah Misch <noah@leadboat.com>, Michael Paquier <michael@paquier.xyz>,
 Anastasia Lubennikova <lubennikovaav@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>,
 Daniel Gustafsson <daniel@yesql.se>, samay sharma <smilingsamay@gmail.com>
References: <20220910200542.GX31833@telsasoft.com>
 <20221104235412.GE16921@telsasoft.com>
 <20221105015946.yrxijqb7h4rqhp6d@awork3.anarazel.de>
 <20221113235303.GA26337@telsasoft.com>
 <20221121224542.p2zapvyvb7objluw@alap3.anarazel.de>
 <20221122225744.GF11463@telsasoft.com>
 <CA+hUKGL=z6-kU80nPTjWqV=Xo=mpM36Lca=ngTr4LqcCf=tHzQ@mail.gmail.com>
 <CA+hUKG+kFpXfCsJQPJApkk7WrBFYYSao0V8q+cj88KQBV8XYRQ@mail.gmail.com>
 <1441145.1675300332@sss.pgh.pa.us>
 <CA+hUKGLNyuvxTcchJe+DK_=_+fZTYCKA4c4o8eDwO5OYc2=qXQ@mail.gmail.com>
 <20230203142656.GA1653@telsasoft.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20230203142656.GA1653@telsasoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/96832c09-db85-8443-c654-dae928816830%40enterprisedb.com>
Precedence: bulk

On 03.02.23 15:26, Justin Pryzby wrote:
> rebased, and re-including a patch to show code coverage of changed
> files.

This constant flow of patches under one subject doesn't lend itself well 
to the commit fest model of trying to finish things up.  I can't quite 
tell which of these patches are ready and agreed upon, and which ones 
are work in progress or experimental.

 > e4534821ef5 cirrus/ccache: use G rather than GB suffix..

This one seems obvious.  I have committed it.

> 9baf41674ad pg_upgrade: tap test: exercise --link and --clone

This seems like a good idea.

> 7e09035f588 WIP: ci/meson: allow showing only failed tests ..

I'm not sure I like this one.  I sometimes look up the logs of 
non-failed tests to compare them with failed tests, to get context to 
could lead to failures.  Maybe we can make this behavior adjustable. 
But I've not been bothered by the current behavior.