Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAApHDvp4nvyt0mMo3qxGLohR2beN3AtzKpyKm98gAO+cvWJ7Mg@mail.gmail.com>
Date: Thu, 18 Jun 2026 14:46:04 +0800
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 Andres Freund <andres@anarazel.de>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <96A79F87-ACDF-479F-B69D-0CACB7085C97@gmail.com>
References: <A4BC563C-0CA3-4EF3-952A-EA41F9E5BF1E@gmail.com>
 <CAApHDvoQKY8zHb1LZBuYZBRszi0qVmTaV_zFup=A9xqRpJWMRQ@mail.gmail.com>
 <pse3eru75b5skbvc7jjrf7origavqojc6nqtwdrr7z6sjkyxfo@siklvj643v4f>
 <BB69B882-5401-45CE-919E-8A78511EDABC@gmail.com>
 <CAApHDvogTSD_G1nkJqOvO3gZFACQUCbKg6U7yBB48r5RMaR7-Q@mail.gmail.com>
 <CAApHDvrJBXEhet4=Es_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@mail.gmail.com>
 <1151393.1781734980@sss.pgh.pa.us> <1174236.1781736349@sss.pgh.pa.us>
 <CAApHDvpE1Jx=NrwUCihrfP+Dmkfn6kUkpCZYC10Yo+wkMu3ssQ@mail.gmail.com>
 <CAApHDvq6FaC441C=G4Q9fNZQ-OKmaeW8yP0YjHpjyjBeWhj3+g@mail.gmail.com>
 <2A622929-A45C-4370-943A-BC76FF4CC433@gmail.com>
 <CAApHDvqrPnvJcTCT6631OHwMbXmP66uOmhrc7-0KG_8kwJ3wPA@mail.gmail.com>
 <03C47613-5C89-4E69-BB72-3B2912BDDDA8@gmail.com>
 <CAApHDvp4nvyt0mMo3qxGLohR2beN3AtzKpyKm98gAO+cvWJ7Mg@mail.gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/96A79F87-ACDF-479F-B69D-0CACB7085C97%40gmail.com>
Precedence: bulk


> On Jun 18, 2026, at 14:27, David Rowley <dgrowleyml@gmail.com> wrote:
>=20
> On Thu, 18 Jun 2026 at 17:56, Chao Li <li.evan.chao@gmail.com> wrote:
>> I don=E2=80=99t know why you added these commented SQL statements, I =
guess you have your reason. The problem is, in the 3 SELECTs, gtest21c =
should probably be gtest21d.
>=20
> This relates to the "-- keep these tests aligned with
> generated_stored.sql" at the top of the file.
>=20
> I mentioned in [1];
>> I pushed the patch to add the new test after modifying it to also
>> include the change in the generated_stored test, but with it =
commented
>> out. This is the method that 83ea6c540 introduced.
>=20
> and this is meant to follow the same pattern.

Thanks for the explanation.

>=20
> I've attached a version with the commented table names fixed. Thanks
> for looking.
>=20
> David
>=20
> [1] =
https://postgr.es/m/CAApHDvrJBXEhet4=3DEs_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@=
mail.gmail.com
> <fix_jit_deform_for_virtual_generated_cols_v3.patch>

This version feels all set.

I also tried to build and run tests, all passed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/