Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: gratuitous casting away const
From: Mark Dilger <hornschnorter@gmail.com>
In-Reply-To: <20919.1474402019@sss.pgh.pa.us>
Date: Tue, 20 Sep 2016 14:33:17 -0700
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <96DBB26C-34FF-4090-98A8-6DDA5136AC73@gmail.com>
References: <ACF3A030-E3D5-4E68-B744-184E11DE68F3@gmail.com>
 <20919.1474402019@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


> On Sep 20, 2016, at 1:06 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Mark Dilger <hornschnorter@gmail.com> writes:
>> Would patches to not cast away const be considered?
>=20
> In general, yes, but I'm not especially in favor of something like this:
>=20
>> bool
>> PageIndexTupleOverwrite(Page page, OffsetNumber offnum,
>> -                                               Item newtup, Size newsiz=
e)
>> +                                               const char *newtup, Size=
 newsize)
>> {
>=20
> since that seems to be discarding type information in order to add
> "const"; does not seem like a net benefit from here.

The following seems somewhere in between, with ItemPointer
changing to const ItemPointerData *.  I expect you would not care
for this change, but thought I'd check to see where you draw the line:


diff --git a/src/backend/access/gin/ginbulk.c b/src/backend/access/gin/ginb=
ulk.c
index 71c64e4..903b01f 100644
--- a/src/backend/access/gin/ginbulk.c
+++ b/src/backend/access/gin/ginbulk.c
@@ -244,7 +244,7 @@ ginInsertBAEntries(BuildAccumulator *accum,
 static int
 qsortCompareItemPointers(const void *a, const void *b)
 {
-   int         res =3D ginCompareItemPointers((ItemPointer) a, (ItemPointe=
r) b);
+   int         res =3D ginCompareItemPointers((const ItemPointerData *) a,=
 (const ItemPointerData *) b);

    /* Assert that there are no equal item pointers being sorted */
    Assert(res !=3D 0);
diff --git a/src/include/access/gin_private.h b/src/include/access/gin_priv=
ate.h
index bf589ab..2e5a7dff 100644
--- a/src/include/access/gin_private.h
+++ b/src/include/access/gin_private.h
@@ -968,7 +968,7 @@ extern ItemPointer ginMergeItemPointers(ItemPointerData=
 *a, uint32 na,
  * so we want this to be inlined.
  */
 static inline int
-ginCompareItemPointers(ItemPointer a, ItemPointer b)
+ginCompareItemPointers(const ItemPointerData *a, const ItemPointerData *b)
 {
    uint64      ia =3D (uint64) a->ip_blkid.bi_hi << 32 | (uint64) a->ip_bl=
kid.bi_lo << 16 | a->ip_posid;
    uint64      ib =3D (uint64) b->ip_blkid.bi_hi << 32 | (uint64) b->ip_bl=
kid.bi_lo << 16 | b->ip_posid;


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers