Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Use SMgrRelation instead of SMgrRelationData * in
 pgaio_io_set_target_smgr()
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <SY7PR01MB10921D0F6F3C2682570D6C31BB645A@SY7PR01MB10921.ausprd01.prod.outlook.com>
Date: Fri, 13 Mar 2026 15:29:31 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <96EB95E4-9032-44A6-A397-153256AA5E4D@gmail.com>
References: 
 <SY7PR01MB10921D0F6F3C2682570D6C31BB645A@SY7PR01MB10921.ausprd01.prod.outlook.com>
To: Japin Li <japinli@hotmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/96EB95E4-9032-44A6-A397-153256AA5E4D%40gmail.com>
Precedence: bulk


> On Mar 13, 2026, at 15:05, Japin Li <japinli@hotmail.com> wrote:
>=20
>=20
> Hi, hackers
>=20
> While reading smgr.h, I noticed an inconsistent type usage in
> pgaio_io_set_target_smgr(). Currently the function is declared as:
>=20
>    extern void pgaio_io_set_target_smgr(PgAioHandle *ioh,
>                                         SMgrRelationData *smgr,
>                                         ForkNumber forknum,
>                                         BlockNumber blocknum,
>                                         int nblocks,
>=20
> However, SMgrRelation is defined as "typedef SMgrRelationData * =
SMgrRelation;",
> and all other functions in the smgr subsystem use SMgrRelation as the =
parameter
> type.
>=20
> To keep the code consistent with the rest of the smgr API, this patch =
changes
> the parameter from SMgrRelationData * to SMgrRelation in both the =
definition
> and declaration.
>=20
> This is purely a style/consistency cleanup with no functional change.
>=20
> Thoughts? Is this change acceptable?
>=20
> --=20
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>=20
> <v1-0001-Use-SMgrRelation-instead-of-SMgrRelationData-in-p.patch>

pgaio_io_set_target_smgr doesn=E2=80=99t update smgr, so, instead of =
=E2=80=9CSMgrRelation=E2=80=9D,  I think it=E2=80=99s better to change =
the type to "const SMgrRelationData *=E2=80=9D.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/