Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Include extension path on pg_available_extensions
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <DE5VKF9UQEVC.1WOJKZ8I9F7XR@gmail.com>
Date: Thu, 13 Nov 2025 17:11:44 +0800
Cc: Rohit Prasad <rohit.prasad@arm.com>,
 pgsql-hackers@lists.postgresql.org,
 mbanck@gmx.net
Content-Transfer-Encoding: quoted-printable
Message-Id: <96F4EB92-C8C3-4E60-A253-E6D789ED79B3@gmail.com>
References: <DCTSKQAVOXIG.3A05JM1YORARK@gmail.com>
 <176282677490.2081919.14769189141245328542.pgcf@coridan.postgresql.org>
 <DE5VKF9UQEVC.1WOJKZ8I9F7XR@gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/96F4EB92-C8C3-4E60-A253-E6D789ED79B3%40gmail.com>
Precedence: bulk

Hi Matheus,

I just reviewed and tested the patch again, got a few more comments:

> On Nov 11, 2025, at 20:47, Matheus Alcantara =
<matheusssilv97@gmail.com> wrote:
>=20
>=20
> On this new v5 version I also swap the order of "comment" and =
"location"
> columns as it was suggested by Michael.
>=20
> --
> Matheus Alcantara
> EDB: http://www.enterprisedb.com
>=20
> <v5-0001-Add-path-of-extension-on-pg_available_extensions.patch>

1 - commit comment
```
User-defined locations are only visible for users that has the
pg_read_extension_paths role, otherwise <insufficient privilege> is
returned as a column value, the same behaviour that we already have on
pg_stat_activity.
```

First, there is a typo: "for users that has=E2=80=9D should be =
=E2=80=9Chave=E2=80=9D.

Then, Is this still true? The code change shows:
```
+	/* We only want to show extension paths for superusers. */
+	if (superuser_arg(GetUserId()))
+	{
```

And the code change says:
```
+       GUC. Only superusers can see the contents of this column.
```

But the TAP test contains a case for normal user:
```
+# Create an user to test permissions to read extension locations.
+my $user =3D "user01";
+$node->safe_psql('postgres', "CREATE USER $user");
+
 my $ecp =3D $node->safe_psql('postgres', 'show =
extension_control_path;');
=20
 is($ecp, "\$system$sep$ext_dir$sep$ext_dir2",
@@ -46,28 +54,46 @@ $node->safe_psql('postgres', "CREATE EXTENSION =
$ext_name2");
 my $ret =3D $node->safe_psql('postgres',
 	"select * from pg_available_extensions where name =3D =
'$ext_name'");
 is( $ret,
-	"test_custom_ext_paths|1.0|1.0|Test extension_control_path",
+	=
"test_custom_ext_paths|1.0|1.0|$ext_dir_canonicalized/extension|Test =
extension_control_path",
 	"extension is installed correctly on =
pg_available_extensions=E2=80=9D);
```

And I tried to run the TAP test, it passed.

So I=E2=80=99m really confused here.

2
```
+	else
+		return "<insufficient privilege>";
+}
```

Why do we just show nothing (empty string)? Every row showing a long =
string of <insufficient privilege> just looks not good, that=E2=80=99s a =
lot of duplications.

```
evantest=3D> select * from pg_available_extension_versions;
        name        | version | installed | superuser | trusted | =
relocatable |   schema   |      requires       |         location        =
 |                                comment
=
--------------------+---------+-----------+-----------+---------+---------=
----+------------+---------------------+--------------------------+-------=
-----------------------------------------------------------------
 refint             | 1.0     | f         | t         | f       | t      =
     |            |                     | <insufficient privilege> | =
functions for implementing referential integrity (obsolete)
 unaccent           | 1.1     | f         | t         | t       | t      =
     |            |                     | <insufficient privilege> | =
text search dictionary that removes accents
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/