Message-ID: <96b4aa732b2c976f6252e0af4892b8a951964daf.camel@j-davis.com>
Subject: Re: alter table set TABLE ACCESS METHOD
From: Jeff Davis <pgsql@j-davis.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org,
 Jacob Champion <pchampion@vmware.com>, Heikki Linnakangas
 <hlinnaka@iki.fi>, Ashwin Agrawal <aagrawal@pivotal.io>,  Ashutosh Sharma
 <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>, Robert Haas
 <robertmhaas@gmail.com>,  Amit Kapila <amit.kapila16@gmail.com>, Alvaro
 Herrera <alvherre@alvh.no-ip.org>, Dilip Kumar <dilipbalaut@gmail.com>
Date: Fri, 04 Jun 2021 17:34:36 -0700
In-Reply-To: <YLq7KsEm63eyH0Yl@paquier.xyz>
References: <20210308010707.GA29832@telsasoft.com>
	 <YEXSj7vO/ypnlIqq@paquier.xyz>
	 <35333ea26e52252174515e14671a9fbc1c20c8fa.camel@j-davis.com>
	 <20210506202305.GQ27406@telsasoft.com>
	 <1033d6b4b5b42a014cc3f617265ae6e61cb5781b.camel@j-davis.com>
	 <20210506221943.GS27406@telsasoft.com>
	 <3bee08c2ca0fab15d14899afcb19490f29e0ec6f.camel@j-davis.com>
	 <803b32e45baf0b05e5f3fc144383db3a18081693.camel@j-davis.com>
	 <YLnA9eFuayKxCr2q@paquier.xyz>
	 <e19c27eeac61434ac3df3f1c3109217a4f14808c.camel@j-davis.com>
	 <YLq7KsEm63eyH0Yl@paquier.xyz>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/96b4aa732b2c976f6252e0af4892b8a951964daf.camel%40j-davis.com>
Precedence: bulk

On Sat, 2021-06-05 at 08:45 +0900, Michael Paquier wrote:
> One thing I am wondering is if we should have a dummy_table_am in
> src/test/modules/ to be able to stress more this feature.  That does
> not seem like a hard requirement, but relying only on heap limits a
> bit the coverage of this feature even if one changes
> default_table_access_method.

I agree that a dummy AM would be good, but implementing even a dummy AM
is a fair amount of work. Also, there are many potential variations, so
we'd probably need several.

The table AM API is a work in progress, and I think it will be a few
releases (and require a few more table AMs in the wild) to really nail
down the API.

Regards,
	Jeff Davis