Feedback-ID: ie0a040ee:Fastmail
Message-ID: <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org>
Date: Thu, 9 Nov 2023 15:41:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: speed up a logical replica setup
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org,
 Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>
References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com>
 <4710d895-689a-4ae6-b8e3-344286dbf970@app.fastmail.com>
 <da078f11-d2de-420e-9611-f3b7d4dadd9a@eisentraut.org>
 <ZUrEclC-uZV-rGd2@paquier.xyz>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ZUrEclC-uZV-rGd2@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/96e3b739-d63d-4d35-90a3-7869465b7167%40eisentraut.org>
Precedence: bulk

On 08.11.23 00:12, Michael Paquier wrote:
> - Should the subdirectory pg_basebackup be renamed into something more
> generic at this point?  All these things are frontend tools that deal
> in some way with the replication protocol to do their work.  Say
> a replication_tools?

Seems like unnecessary churn.  Nobody has complained about any of the 
other tools in there.

> - And if it would be better to refactor some of the code generic to
> all these streaming tools to fe_utils.  What makes streamutil.h a bit
> less pluggable are all its extern variables to control the connection,
> but perhaps that can be an advantage, as well, in some cases.

Does anyone outside of pg_basebackup + existing friends + new friend 
need that?  Seems like extra complications.