Message-ID: <972a4e12b68b0f96db514777a150ceef7dcd2e0f.camel@crunchydata.com>
Subject: Bug fix. autovacuum.c do_worker_start() associates memory
 allocations with TopMemoryContext rather than 'Autovacuum start worker
 (tmp)'
From: Reid Thompson <reid.thompson@crunchydata.com>
Reply-To: reid.thompson@crunchydata.com
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Cc: reid.thompson@crunchydata.com
Organization: Crunchy Data
Content-Type: multipart/mixed; boundary="=-HnR0nty7RQVHZi+LJz3l"
Date: Wed, 31 Aug 2022 12:10:26 -0400
MIME-Version: 1.0
User-Agent: Evolution 3.45.1 Compiled: 2022-06-07 10:22:05
Archived-At: 
 <https://www.postgresql.org/message-id/972a4e12b68b0f96db514777a150ceef7dcd2e0f.camel%40crunchydata.com>
Precedence: bulk

--=-HnR0nty7RQVHZi+LJz3l
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Hackers,

This patch ensures get_database_list() switches back to the memory
context in use upon entry rather than returning with TopMemoryContext
as the context.

This will address memory allocations in autovacuum.c being associated
with TopMemoryContext when they should not be.

autovacuum.c do_start_worker() with current context
'Autovacuum start worker (tmp)' invokes get_database_list(). Upon
return, the current context has been changed to TopMemoryContext by
AtCommit_Memory() as part of an internal transaction. Further down
in the do_start_worker(), pgstat_fetch_stat_dbentry() is invoked.
Previously this didn't pose a issue, however recent changes altered
how pgstat_fetch_stat_dbentry() is implemented. The new
implementation has a branch utilizing palloc. The patch ensures these
allocations are associated with the 'Autovacuum start worker (tmp)'
context rather than the TopMemoryContext. Prior to the change,
leaving an idle laptop PG instance running just shy of 3 days saw the
autovacuum launcher process grow to 42MB with most of that growth in
TopMemoryContext due to the palloc allocations issued with autovacuum
worker startup.


--=20
Reid Thompson
Senior Software Engineer
Crunchy Data, Inc.

reid.thompson@crunchydata.com
www.crunchydata.com


--=20
Reid Thompson
Senior Software Engineer
Crunchy Data, Inc.

reid.thompson@crunchydata.com
www.crunchydata.com

--=-HnR0nty7RQVHZi+LJz3l
Content-Disposition: attachment;
 filename="001-dev-get-dblist-memorycontext.patch"
Content-Type: text/x-patch; name="001-dev-get-dblist-memorycontext.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvYXV0b3ZhY3V1bS5jIGIvc3JjL2Jh
Y2tlbmQvcG9zdG1hc3Rlci9hdXRvdmFjdXVtLmMKaW5kZXggYjNiMWFmYmE4Ni4uOTJiMWVmNDVj
MSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9hdXRvdmFjdXVtLmMKKysrIGIv
c3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9hdXRvdmFjdXVtLmMKQEAgLTE5NDEsNiArMTk0MSwxMyBA
QCBnZXRfZGF0YWJhc2VfbGlzdCh2b2lkKQogCiAJQ29tbWl0VHJhbnNhY3Rpb25Db21tYW5kKCk7
CiAKKwkvKgorCSAqIENvbW1pdFRyYW5zYWN0aW9uQ29tbWFuZCByZXR1cm5zIHdpdGggQ3VycmVu
dE1lbW9yeUNvbnRleHQgc2V0CisJICogdG8gVG9wTWVtb3J5Q29udGV4dC4gU3dpdGNoIGJhY2sg
dG8gdGhlIGNvbnRleHQgdGhhdCB3ZSBlbnRlcmVkCisJICogd2l0aC4KKwkgKi8KKwlNZW1vcnlD
b250ZXh0U3dpdGNoVG8ocmVzdWx0Y3h0KTsKKwogCXJldHVybiBkYmxpc3Q7CiB9CiAK


--=-HnR0nty7RQVHZi+LJz3l--