Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjQM7-0006nD-Mi for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Nov 2020 17:19:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kjQM6-00015G-CQ for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Nov 2020 17:19:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjQM6-000159-5D for pgsql-hackers@lists.postgresql.org; Sun, 29 Nov 2020 17:19:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjQLz-0000rZ-RV for pgsql-hackers@lists.postgresql.org; Sun, 29 Nov 2020 17:19:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0ATHJAKT973006; Sun, 29 Nov 2020 12:19:10 -0500 From: Tom Lane To: Michael Paquier cc: Paul =?iso-8859-1?Q?F=F6rster?= , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Subject: Re: configure and DocBook XML In-reply-to: References: <20201126141932.GA7253@alvherre.pgsql> <620466.1606407716@sss.pgh.pa.us> <364B7A1C-1E08-4664-AA19-CA47A6B547C8@gmail.com> <621545.1606409302@sss.pgh.pa.us> <2A6DAAFD-5193-47A6-B3BA-55B869EBCE2F@gmail.com> <704639.1606490964@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Sun, 29 Nov 2020 16:14:39 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <973004.1606670350.1@sss.pgh.pa.us> Date: Sun, 29 Nov 2020 12:19:10 -0500 Message-ID: <973005.1606670350@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Fri, Nov 27, 2020 at 10:29:24AM -0500, Tom Lane wrote: >> To me, it makes sense to have an option to do that, but I do find it >> surprising that it's the default. > But there is no need for an option, right? It is already possible to > override the location where xmllint looks for the catalogs by setting > SGML_CATALOG_FILES and XML_CATALOG_FILES. But the issue here is about what happens when you don't have a local copy of the DTD. I don't think adjusting those variables will change that. Anyway, I think that the other thread is coming to the conclusion that it's okay to just document how to inject --nonet via configure, so we don't need to touch the makefiles. As long as we get rid of the unrequested network fetch during configure, it's okay by me if an actual attempt to build the docs will possibly cause a network fetch. regards, tom lane