From: Tom Lane <tgl@sss.pgh.pa.us>
To: Aleksander Alekseev <aleksander@timescale.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: ExecTypeSetColNames is fundamentally broken
In-reply-to: <CAJ7c6TPfqfvB8AShZir1R054Wn7M5G4i_SgRM9K9-kADys8qEg@mail.gmail.com>
References: <2950001.1638729947@sss.pgh.pa.us> <CA+TgmoaYDAqLLmxo_d9h2SZ1Mw28M9w5QZMuZcaL6D2JdG_B6w@mail.gmail.com> <3360468.1638824732@sss.pgh.pa.us> <CA+Tgmoa2Fm+4eDb6O4NFzA-u78k2Wa0-V48qimSVgBbCF2MvDg@mail.gmail.com> <3501514.1638898248@sss.pgh.pa.us> <CA+TgmoYX8ZsL5BoYeJD+QK9iCQLBdq1mbQ_ZiwZGKBwzgFZYWA@mail.gmail.com> <3504581.1638901169@sss.pgh.pa.us> <CA+TgmoZx+_6VqwZmG4Re5geiC=Jas=mAc0Jjve=b0AHVWi4q3g@mail.gmail.com> <CAJ7c6TPfqfvB8AShZir1R054Wn7M5G4i_SgRM9K9-kADys8qEg@mail.gmail.com>
Comments: In-reply-to Aleksander Alekseev <aleksander@timescale.com>
	message dated "Wed, 16 Mar 2022 15:47:15 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <973179.1647556091.1@sss.pgh.pa.us>
Date: Thu, 17 Mar 2022 18:28:11 -0400
Message-ID: <973180.1647556091@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/973180.1647556091%40sss.pgh.pa.us>
Precedence: bulk

Aleksander Alekseev <aleksander@timescale.com> writes:
> I understand the concern expressed by Robert in respect of backward
> compatibility. From the user's perspective, personally I would prefer
> a fixed bug over backward compatibility. Especially if we consider the
> fact that the current behaviour of cases like `select row_to_json(i)
> from int8_tbl i(x,y)` is not necessarily the correct one, at least it
> doesn't look right to me.

It's debatable anyway.  I'd be less worried about changing this behavior
if we didn't have to back-patch it ... but I see no good alternative.

> So unless anyone has strong objections against the proposed fix or can
> propose a better patch, I would suggest merging it.

Done now.

			regards, tom lane