Message-ID: <97595af5-9264-4e5f-a270-098af02d54e9@gmail.com>
Date: Thu, 17 Aug 2023 07:57:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: WIP: new system catalog pg_wait_event
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, tgl@sss.pgh.pa.us,
 pgsql-hackers@lists.postgresql.org
References: <ZNGw9T2t5z5Kg1xd@paquier.xyz>
 <b21e5706-b6dd-42f1-a744-3afffe87c2c9@gmail.com>
 <c915434a-3d3a-4135-8f3a-fca0cf22c6ae@gmail.com>
 <ZNNGq7DTv9ur5113@paquier.xyz>
 <b71d1977-1a8b-4129-8c03-533031dbd004@gmail.com>
 <ZNmvegQirGI9ifVw@paquier.xyz>
 <2f84b397-d020-493c-924c-610b9dd18f8d@gmail.com>
 <ZNxrMdmgrlovw1qD@paquier.xyz>
 <f2204399-cfdb-40e7-9479-9373ec6ba0ab@gmail.com>
 <735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com>
 <ZN1+cBP2ppLsy3LA@paquier.xyz>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZN1+cBP2ppLsy3LA@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/97595af5-9264-4e5f-a270-098af02d54e9%40gmail.com>
Precedence: bulk

Hi,

On 8/17/23 3:57 AM, Michael Paquier wrote:
> On Thu, Aug 17, 2023 at 10:53:02AM +0900, Masahiro Ikeda wrote:
>> BTW, although I think this is outside the scope of this patch,
>> it might be a good idea to be able to add a description to the
>> API for custom wait events.
> 
> Somebody on twitter has raised this point.

I think I know him ;-)

>  I am not sure that we need
> to go down to that for the sake of this view, but I'm OK to..
> Disagree and Commit to any consensus reached on this matter.

Yeah, I changed my mind of this. I think it's better to keep the
"control" about what is displayed in the description field for
this new system view.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com