Subject: Re: prevent immature WAL streaming
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 "Bossart, Nathan" <bossartn@amazon.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 "andres@anarazel.de" <andres@anarazel.de>,
 "masao.fujii@oss.nttdata.com" <masao.fujii@oss.nttdata.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "mengjuan.cmj@alibaba-inc.com" <mengjuan.cmj@alibaba-inc.com>,
 "Jakub.Wartak@tomtom.com" <Jakub.Wartak@tomtom.com>,
 Ryo Matsumura <matsumura.ryo@fujitsu.com>
References: <202109291443.dxsnnji7a4dq@alvherre.pgsql>
 <3000074.1632947632@sss.pgh.pa.us>
 <06126430-07db-7051-a4c7-17edbe4ac34e@dunslane.net>
 <3003011.1632950979@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Message-ID: <97ccf47e-e4f9-28b6-e780-83821f1da69c@dunslane.net>
Date: Thu, 30 Sep 2021 10:18:39 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <3003011.1632950979@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/97ccf47e-e4f9-28b6-e780-83821f1da69c%40dunslane.net>
Precedence: bulk


On 9/29/21 5:29 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 9/29/21 4:33 PM, Tom Lane wrote:
>>> which looks like a pretty straightforward bogus-connection-configuration
>>> problem, except why wouldn't other BF members show it?
>> This:
>> ...
>> doesn't have "allows_streaming => 1".
> Oh, and that only breaks things on Windows, cf set_replication_conf.
>
> ... although I wonder why the fact that sub init otherwise sets
> wal_level = minimal doesn't cause a problem for this test.
> Maybe the test script is cowboy-ishly overriding that?
>
> 			


Regardless of this problem, I think we should simply call
set_replication_conf unconditionally in init().  Replication connections
are now allowed by default on Unix, this would just bring Windows nodes
into line with that.


The function does have this:

    $self->host eq $test_pghost
       or die "set_replication_conf only works with the default host";

I'm not sure when that wouldn't be true.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com