Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 020166343E3 for ; Sat, 19 Sep 2009 13:18:10 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 56327-10 for ; Sat, 19 Sep 2009 16:18:02 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yw0-f199.google.com (mail-yw0-f199.google.com [209.85.211.199]) by mail.postgresql.org (Postfix) with ESMTP id 57E3F633E3F for ; Sat, 19 Sep 2009 13:18:02 -0300 (ADT) Received: by ywh37 with SMTP id 37so2048829ywh.28 for ; Sat, 19 Sep 2009 09:18:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.23.2 with SMTP id 2mr1938108agw.56.1253377081108; Sat, 19 Sep 2009 09:18:01 -0700 (PDT) In-Reply-To: <87ws3vn2pe.fsf@news-spur.riddles.org.uk> References: <87zl8v36qo.fsf@news-spur.riddles.org.uk> <39EDBE64-BE43-4A3E-9514-D7EB2EAD6D35@kineticode.com> <87ws3vn2pe.fsf@news-spur.riddles.org.uk> Date: Sat, 19 Sep 2009 18:18:01 +0200 Message-ID: <9837222c0909190918u7bd2ea89tfcb35016f6d44a91@mail.gmail.com> Subject: Re: updated hstore patch From: Magnus Hagander To: Andrew Gierth Cc: "David E. Wheeler" , pgsql-hackers@postgresql.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200909/1296 X-Sequence-Number: 146102 On Sat, Sep 19, 2009 at 03:27, Andrew Gierth wrote: > However, I would prefer to keep the ability to do this: > > psql --set hstore_schema='myschema' -f hstore.sql dbname > > The logic to do it is a bit ugly, but editing the file to set what schema to > use is even uglier... That seems like a pretty good thing to have, but that shouldn't be in the hstore patch. If we want to do that, we should do it for *all* contrib modules, so they are consistent. Which I think would be good, but given previous discussions I'm sure somebody is going ot have an argument against it... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/