public inbox for [email protected]  

help / color / mirror / Atom feed

From: Antonin Houska <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Srinath Reddy Sadipiralla <[email protected]>
Cc: [email protected]
Subject: Re: Teach isolation tester about injection points in background workers
Date: Mon, 30 Mar 2026 15:29:47 +0200
Message-ID: <98380.1774877387@localhost> (raw)
In-Reply-To: <[email protected]>
References: <4703.1774250534@localhost>
	<CAFC+b6rYYQ6CqXYYsmnLeWsCe7mDa9PhbM8=KYFB0X+XOYexEg@mail.gmail.com>
	<[email protected]>

Michael Paquier <[email protected]> wrote:

> On Tue, Mar 24, 2026 at 04:25:47PM +0530, Srinath Reddy Sadipiralla wrote:
> > +1. I was thinking can we move the logic of checking if bg workers are the
> > reason of blocking the main backend
> > inside pg_isolation_test_session_is_blocked
> > to make it cleaner, and regarding "XXX Should we use a separate query for
> > that?"
> > i am confused here IIUC if we keep it as 1 query using UNION every time its
> > for sure
> > that both the queries will run, which can increase more execution time but
> > less libpq/socket
> > calls, but if we send as 2 queries if 1st query doesn't returns true we
> > have to go and
> > check the other query, so here if 2 queries ran then execution +
> > libpq/socket calls overhead,
> > so i am slightly inclined towards separating the queries , so that if 1st
> > gets satisfied then
> > we don't touch the 2nd query at all, please correct me if i am wrong here :)
> 
> Is there a benefit in this change outside the hypothetical REPACK
> CONCURRENTLY?

Not at the moment. Perhaps I shouldn't pursue this patch until there's an
injection point in the tree that needs that.

> Using separating queries may make more sense on readability ground, at
> least.

Agreed.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Teach isolation tester about injection points in background workers
  In-Reply-To: <98380.1774877387@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox