From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Geoghegan <pg@bowt.ie>, Noah Misch <noah@leadboat.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: AIX support - alignment issues
In-reply-to: <20220702205149.k5qp42n2ztuuhui2@alap3.anarazel.de>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
 <CAH2-WzndKXQQGh-7sCOTKL_87Kt918r0F2ztTAraeBCAC8v3OQ@mail.gmail.com>
 <968410.1656789743@sss.pgh.pa.us>
 <CAH2-WzmnoGPN--Z7MfTqv2TTVLJF0Y0tzZbGUS-NAwJ0wv15hw@mail.gmail.com>
 <977853.1656794075@sss.pgh.pa.us>
 <20220702205149.k5qp42n2ztuuhui2@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 02 Jul 2022 13:51:49 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <985074.1656797514.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 02 Jul 2022 17:31:54 -0400
Message-ID: <985075.1656797514@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/985075.1656797514%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> What made me look at this issue right now is that the alignment issue le=
ad the
> 56bit relfilenode patch to move the relfilenode field to the start of pg=
_class
> (ahead of the oid),

Agreed, up with that we should not put.  However ...

> because a 64bit value cannot be after a NameData.

... this coding rule strikes me as utterly ridiculous.  Why can't we
instead insist that NAMEDATALEN must be a multiple of 8?  Anyone who
tries to make it different from that is likely to be wasting padding
space even on platforms where there's not a deeper problem.

			regards, tom lane