Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pU2mA-0001YC-VB
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Feb 2023 09:48:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pU2m9-00020f-Ri
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Feb 2023 09:48:01 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <e.indrupskaya@postgrespro.ru>)
	id 1pU2m9-00020T-DD
	for pgsql-hackers@lists.postgresql.org; Mon, 20 Feb 2023 09:48:01 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by makus.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <e.indrupskaya@postgrespro.ru>)
	id 1pU2m6-0003zO-8g
	for pgsql-hackers@postgresql.org; Mon, 20 Feb 2023 09:48:00 +0000
Received: from [192.168.28.21] (cyclops.postgrespro.ru [93.174.131.138])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id 3EFBE21CA123;
	Mon, 20 Feb 2023 12:47:55 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1676886475;
	bh=D7xSUt4opsIBk82DnDMRgq+zHe8dAsvg0T5KdxvBAGo=;
	h=Date:From:Subject:To:Cc:References:In-Reply-To;
	b=hj0t2c0xCevA1tpgzSXvWjTWmo2xokd8Z1kcDH2qY4VRPL3hr+rQ3vJp1MoCeY6Pb
	 xNxI7bIFCUhXAMD+V08T0ioXNXdc2t+aLW6dydP6UWyuQTClmIhZ+Ur1MMtsMBbC3h
	 5N2TcEL5ikciijuPvJIrYJykBVs/1PBq1k0B9B5U=
Message-ID: <987a46a8-5a15-cd5c-0ef3-cfd94f15bd61@postgrespro.ru>
Date: Mon, 20 Feb 2023 12:47:54 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
From: e.indrupskaya@postgrespro.ru
Subject: Re: SQL/JSON revisited
Content-Language: en-US
To: Amit Langote <amitlangote09@gmail.com>, vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
References: 
 <CA+HiwqHROpf9e644D8BRqYvaAPmgBZVup-xKMDPk-nd4EpgzHw@mail.gmail.com>
 <CA+HiwqE9aeaOTvTZ4xP37ieS2TN6WsV2MrSha2qtzsF8gV229w@mail.gmail.com>
 <CALDaNm1b8NZgxSESw2u5GNcDbMNGnXujN7f-XxUL506hXert5g@mail.gmail.com>
 <CA+HiwqEmsVHC23fry0S9T_3ZNsT=6R25vi2DEkE9s3wDskic_w@mail.gmail.com>
 <CA+HiwqEgGJsdb4keqbXHUEtsRiNf8UAEqBQQe6k=98AkGGG0gQ@mail.gmail.com>
In-Reply-To: 
 <CA+HiwqEgGJsdb4keqbXHUEtsRiNf8UAEqBQQe6k=98AkGGG0gQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/987a46a8-5a15-cd5c-0ef3-cfd94f15bd61%40postgrespro.ru>
Precedence: bulk

Hi Amit and Andrew,

Regarding not squashing [PATCH v3 11/11] Proposed reworking of
SQL/JSON documentaion, here is exactly what Tom Lane wrote in the comment to commit 47046763c3:

Use <parameter>
     consistently for things that are in fact names of parameters (including
     OUT parameters), reserving <replaceable> for things that aren't.

Following this, <parameter> tags should be replaced with <replaceable> because
the SQL/JSON functions' code does not explicitly specify those tagged variables
as function parameters. Doesn't it convince you to look at the patch again? Thank you.

On 20.02.2023 10:35, Amit Langote wrote:
>> no parameter names in the functions' code either
> Hi,
>
> On Mon, Jan 30, 2023 at 3:39 PM Amit Langote <amitlangote09@gmail.com> wrote:
>> On Fri, Jan 27, 2023 at 11:27 PM vignesh C <vignesh21@gmail.com> wrote:
>>> On Tue, 17 Jan 2023 at 19:01, Amit Langote <amitlangote09@gmail.com> wrote:
>>>> And I've just finished doing that.  In the attached updated 0004,
>>>> which adds the JsonExpr node, its evaluation code is now broken into
>>>> ExprEvalSteps to handle the subsidiary JsonCoercion and JsonBehavior
>>>> expression nodes that previously used ExprState for recursive
>>>> evaluation.  Andres didn't like the latter as previously discussed at
>>>> [1].
>>>>
>>>> I've also attached the patch that Elena has proposed as the patch
>>>> 0011.  I haven't managed to review it yet, though once I do, I'll
>>>> merge it into the main documentation patch 0009.  Thanks Elena.
>>> The patch does not apply on top of HEAD as in [1], please post a rebased patch:
>> Thanks for the heads up.  Here's a rebased version.
> Rebased again over queryjumble overhaul.
>
> I decided to squash what was "[PATCH v3 01/11] Common SQL/JSON
> clauses" into "[PATCH v3 02/11] SQL/JSON constructors", because I
> noticed "useless productions" warnings against its gram.y additions
> when building just 0001.
>
> I also looked at squashing "[PATCH v3 11/11] Proposed reworking of
> SQL/JSON documentaion" into "[PATCH v3 09/11] Documentation for
> SQL/JSON features", but didn't, again, because I am still not sure
> which one of <parameter> and <replaceable> is correct for the SQL/JSON
> function constructs.  Maybe it's the latter looking at the markup for
> some text on [1], such as exists ( path_expression ) → boolean, but
> Andrew sounded doubtful about that upthread.
>