Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfpMU-005HsV-12 for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jan 2026 01:07:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vfpMT-00772J-0f for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jan 2026 01:07:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfpMS-007727-2O for pgsql-hackers@lists.postgresql.org; Wed, 14 Jan 2026 01:07:49 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfpMQ-000KLn-2l for pgsql-hackers@lists.postgresql.org; Wed, 14 Jan 2026 01:07:48 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 4D27744C157 for ; Wed, 14 Jan 2026 02:07:45 +0100 (CET) Received: from s934.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 32C4E44C0E5; Wed, 14 Jan 2026 02:07:45 +0100 (CET) Received: from s473.loopia.se (unknown [172.22.191.6]) by s934.loopia.se (Postfix) with ESMTP id 303B77CEA69; Wed, 14 Jan 2026 02:07:45 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s473.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=proxel.se Received: from s981.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id bftMwndslbB9; Wed, 14 Jan 2026 02:07:44 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s981.loopia.se (Postfix) with ESMTPSA id 932F422B1692; Wed, 14 Jan 2026 02:07:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1768352864; bh=Gl+ETaC14wnVf+bj2mPKvErfCsKk+2vUUdgd98XpXBE=; h=Date:Subject:To:References:From:In-Reply-To; b=OyiyoG+AZrZeusOhEGl+qJXPSby0eCkZqFudvWaGIOZnuOU/cty29+LbZ9GbqFn+A rinHlTzUy6Z5zErETHy7cIEUnoOGVYKOuL+JMsy7vWqz70moR8AKEASWlxopFCLFhq 4cOiAtmJHMJxHLt9rKK2+s9hpM+nDVHHqRqKTSn4KBt32JzIiGLJij2C/b+OLxXVbL HPX1e2JKVrpzHn3iF4vN/feg4QXW0GPaELwSu1m/r3myQTKRn9lj4uslXLU4PYIXOH 2L2CE9sQVRGGS1GMC0qICSta0/unsKa/FXC1j9dDWYVHYy4QaY8orjiA9iusQvS7Hl VTuYZC7y4JPUw== Message-ID: <98b4032e-64b9-4d36-bc65-2dc4d0d80a58@proxel.se> Date: Wed, 14 Jan 2026 02:07:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] check kernel version for io_method To: Pierre , pgsql-hackers@lists.postgresql.org References: <17879f12-609b-4730-bfff-6dd11a46d5e6@gmail.com> From: Andreas Karlsson Content-Language: en-US In-Reply-To: <17879f12-609b-4730-bfff-6dd11a46d5e6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 1/13/26 11:05 PM, Pierre wrote: > Please find a patch proposal for bug BUG #19369: Not documented that > io_uring on kernel versions between 5.1 and below 5.6 does not work. Wouldn't it make more sense to use io_uring_get_probe_ring() and io_uring_opcode_supported() to actually check for the required opcode? Then if someone uses a Kernel with the required features backported everything will still work. Andreas