Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcpQU-0004pR-Bp for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Nov 2020 12:40:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kcpQT-00052m-8m for pgsql-hackers@arkaria.postgresql.org; Wed, 11 Nov 2020 12:40:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcpQT-00052f-20 for pgsql-hackers@lists.postgresql.org; Wed, 11 Nov 2020 12:40:37 +0000 Received: from wforward1-smtp.messagingengine.com ([64.147.123.30]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcpQQ-0002aD-GR for pgsql-hackers@postgresql.org; Wed, 11 Nov 2020 12:40:35 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailforward.west.internal (Postfix) with ESMTP id 1C2B319E3; Wed, 11 Nov 2020 07:40:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 11 Nov 2020 07:40:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JW/zz+GQJRy9Jb8LvtBRjlHC71QI8J+DqWI/Q4/Ch nw=; b=SeaWSVTkMZDcG/Wc0Vnf47TH/hr9UmmZJm68NFcz8E5MsR2NPWQwuDfqs CJb5Sa6ZweMPAvvffLj541/SSH3aaxWGjQVmO7eYKScUPuOiz3pt8rVoqKXtXzwa uajBSiMFmzhCafcSJxF6ykE6bkxvJ7JuJZYjz8Puc0VJcuOD5xgQwjWAgrHYb2Nu ghwMNoD00cZNyDaPJFvpapYJMqFX4quKDBhp/ZB15sk2KYyNtGx/4bcciHsvw3UK Hyk2TCum2uQ5YDMmtg1D4m4moOL27NCv4P+Ox3QSjfIwQ/HqsFPL2iNIbYy/Ose4 PzezYzNvJMj/9Pu8NXu1skLLCFTwg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduledgudehvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhohfkffgfgggjtgfgse htjeertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvght vghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtf frrghtthgvrhhnpeehheeijefgvefhvdehleekueevhfehhedvheetgffhteefgeeggfev jeejfffgvdenucfkphepkeejrddujeejrdejhedrleegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: from april.pezone.net (p57b14b5e.dip0.t-ipconnect.de [87.177.75.94]) by mail.messagingengine.com (Postfix) with ESMTPA id CF165328005A; Wed, 11 Nov 2020 07:40:31 -0500 (EST) Subject: Re: Clean up optional rules in grammar To: Vik Fearing , pgsql-hackers References: <0e608c89-3b1d-1dbf-7c03-423f15dcbbed@postgresfriends.org> From: Peter Eisentraut Organization: EnterpriseDB Message-ID: <98ddbd3e-392e-589e-40a7-643111ce03f1@enterprisedb.com> Date: Wed, 11 Nov 2020 13:40:31 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0e608c89-3b1d-1dbf-7c03-423f15dcbbed@postgresfriends.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-11-11 12:43, Vik Fearing wrote: > No objections, but could we also take this opportunity to standardize > the comment itself? Even in your patch there is a mix of spacing and > casing. > > My preference is /* EMPTY */. That is, uppercase with spaces, but > whatever gets chosen is fine with me. Looks like /*EMPTY*/ is the most common right now. I agree this should be straightened out.