public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Mark Wong <[email protected]>
Cc: Andreas Karlsson <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: updates for handling optional argument in system functions
Date: Wed, 8 Apr 2026 10:09:51 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwZ3QDK+kW+PQ1e00fXEgFasUUcLUrjgZJ4-OkKqb5D7yg@mail.gmail.com>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
	<ac63G6p1LAdbsca0@ltdrgnflg2>
	<[email protected]>
	<[email protected]>
	<adWWxf5YrHATATw3@ltdrgnflg2>
	<[email protected]>
	<CAKFQuwZ3QDK+kW+PQ1e00fXEgFasUUcLUrjgZJ4-OkKqb5D7yg@mail.gmail.com>



> On Apr 8, 2026, at 09:46, David G. Johnston <[email protected]> wrote:
> 
> On Tuesday, April 7, 2026, Chao Li <[email protected]> wrote:
> 
> We can clearly see ":expr {FUNCEXPR :funcid 1573 “.
> 
> With this patch, will that view break? How would users find all such broken views? Maybe PostgreSQL already has some recommended way to handle this kind of situation that I am not aware of?
> 
> pg_dump resolves oid=1573 and produces a textual SQL representation, which is then executed during pg_restore.  This happens manually, and also automatically by pg_upgrade.  Since the text form hasn’t changed the view is still valid in v19.  You would see the new oid if inspecting the rule after the upgrade.
> 
> So yes, the public serialization format being SQL and thus mandatory new object creation during upgrade is the way PostgreSQL handles implementation detail isolation.
> 
> David J.
> 

Hi David, thanks for the explanation, I really didn’t know that.

Then, the patch looks good to me. GET_PRETTY_FLAGS(false) returns PRETTYFLAG_INDENT, so no behavior change either.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: updates for handling optional argument in system functions
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox