Subject: Re: Add a description to the documentation that toast_tuple_target
 affects "Main"
To: Shinya Okano <btokanosn@oss.nttdata.com>,
 Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <93f46e311a67422e89e770d236059817@oss.nttdata.com>
 <CAP0=ZVJ9Wh2RnphL4nB6PuhODCxeMBBkzg3=5oSu+1FMOaNK6Q@mail.gmail.com>
 <a4941ace-b898-3bd4-270f-2ccc1dc2af07@oss.nttdata.com>
 <cfe3c1f5f0987c70ddde187d411739e3@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <992966ae-7e8c-9adb-054a-243d74ac487a@oss.nttdata.com>
Date: Thu, 15 Oct 2020 11:12:10 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <cfe3c1f5f0987c70ddde187d411739e3@oss.nttdata.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2020/10/14 16:21, Shinya Okano wrote:
> On 2020-10-14 01:30, Fujii Masao wrote:
>> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>>> documentation says that it only affects External or Extended, but it
>>>> actually affects the compression of Main as well.
>>>>
>>>> The attached patch modifies the document to match the actual behavior.
>>> +1
>>
>> +1
>>
>> +      we try to compress long column values or to move into TOAST tables, and
>>
>> "we try to compress and/or move long column values into TOAST tables,
>> and" is better?
> 
> Thank you everyone for reviews.
> I attached the new version of the patch.

Thanks for updating the patch! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION