Message-ID: <99347349-ff6b-c580-531d-f12aec64caad@gmail.com>
Date: Fri, 24 May 2024 23:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Korotkov <aekorotkov@gmail.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>, Dmitry Koval <d.koval@postgrespro.ru>,
 pgsql-hackers@lists.postgresql.org,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
References: <fdaa003e-919c-cbc9-4f0c-e4546e96bd65@gmail.com>
 <edfbd846-dcc1-42d1-ac26-715691b687d3@postgrespro.ru>
 <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023>
 <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023>
 <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com>
 <Zjvwqs-GV0MjWIhU@pryzbyj2023>
 <CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
 <ZkN6EfjQGz8TOhbL@pryzbyj2023>
 <CAPpHfdvz3S7SoRiaSk9C-Juy2EzHs6NC_c9uUR0i7bymKXkvuQ@mail.gmail.com>
 <CALT9ZEHCDCXvg_=9oPb99mHzJPE=+N-DOodsuE20UorY35Jkzw@mail.gmail.com>
 <CAPpHfduYTTATcdm_gTr2O9NM+CeaEPy9WhL=ycaQUxGqcgnKvA@mail.gmail.com>
 <695264.1716578979@sss.pgh.pa.us>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <695264.1716578979@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/99347349-ff6b-c580-531d-f12aec64caad%40gmail.com>
Precedence: bulk

Hello,

24.05.2024 22:29, Tom Lane wrote:
> The partition_split test has unstable results, as shown at [1].
> I suggest adding "ORDER BY conname" to the two queries shown
> to fail there.  Better look at other queries in the test for
> possible similar problems, too.

Yes, I've just reproduced it on an aarch64 device as follows:
echo "autovacuum_naptime = 1
autovacuum_vacuum_threshold = 1
autovacuum_analyze_threshold = 1
" > ~/temp.config
TEMP_CONFIG=~/temp.config TESTS="$(printf 'partition_split %.0s' `seq 100`)" make -s check-tests
...
ok 80        - partition_split                           749 ms
not ok 81    - partition_split                           728 ms
ok 82        - partition_split                           732 ms

$ cat src/test/regress/regression.diffs
diff -U3 .../src/test/regress/expected/partition_split.out .../src/test/regress/results/partition_split.out
--- .../src/test/regress/expected/partition_split.out   2024-05-15 17:15:57.171999830 +0000
+++ .../src/test/regress/results/partition_split.out    2024-05-24 19:28:37.329999749 +0000
@@ -625,8 +625,8 @@
  SELECT pg_get_constraintdef(oid), conname, conkey FROM pg_constraint WHERE conrelid = 
'sales_feb_mar_apr2022'::regclass::oid;
pg_get_constraintdef                         | conname             | conkey
  ---------------------------------------------------------------------+---------------------------------+--------
- CHECK ((sales_amount > 1))                                          | sales_range_sales_amount_check  | {2}
   FOREIGN KEY (salesperson_id) REFERENCES salespeople(salesperson_id) | sales_range_salesperson_id_fkey | {1}
+ CHECK ((sales_amount > 1))                                          | sales_range_sales_amount_check  | {2}
  (2 rows)

  ALTER TABLE sales_range SPLIT PARTITION sales_feb_mar_apr2022 INTO

Best regards,
Alexander