Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <20201105.121206.819769369617763972.horikyota.ntt@gmail.com>
 <bc313fdc-2beb-52d1-b8a7-ef1e4cfb92bf@oss.nttdata.com>
 <CALj2ACWz1R+gRt2zJCSsWZeCgQhnM6-E-4XFotqqUwbyYk7ZEA@mail.gmail.com>
 <20201110.161740.1341818036035711165.horikyota.ntt@gmail.com>
 <eeda13ff-9ed4-747b-b47b-a7983e2fab40@oss.nttdata.com>
 <CALj2ACXPEW6wpx+-s5dqcDV2Y+G0U-wu79ZHr7mPRF8G_YwB-Q@mail.gmail.com>
 <763d6041-49d3-96b2-d0ec-f56e676a5156@oss.nttdata.com>
 <CALj2ACUmb7DS2ezexRexhSTFAtD8Bm7Z9=-oXucag=c5ZWdxpw@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <997775df-e13d-1e73-807d-08610e7e9c75@oss.nttdata.com>
Date: Tue, 17 Nov 2020 17:16:52 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: 
 <CALj2ACUmb7DS2ezexRexhSTFAtD8Bm7Z9=-oXucag=c5ZWdxpw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/11/13 20:24, Bharath Rupireddy wrote:
> On Thu, Nov 12, 2020 at 10:06 AM Fujii Masao
> <masao.fujii@oss.nttdata.com> wrote:
>>
>> Thanks for the analysis! I pushed the patch.
>>
> 
> Thanks! Since we are replacing custom SIGHUP and SIGTERM handlers with
> standard ones, how about doing the same thing in worker_spi.c? I
> posted a patch previously [1] in this mail thread. If it makes sense,
> please review it.

I agree to simplify the worker_spi code by making it use the standard
signal handlers. But as far as I read Craig Ringer's comments upthread
about worker_spi, it's not enough to just replace the dedicated SIGTERM
handler with the standard one. ISTM that probably worker_spi should
use the signal handler handling InterruptPending and ProcDiePending
like die() does. What do you think about Craig Ringer's comments?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION