From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Chao Li <li.evan.chao@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
        Andres Freund <andres@anarazel.de>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns
In-reply-to: 
 <CAApHDvrJBXEhet4=Es_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@mail.gmail.com>
References: <A4BC563C-0CA3-4EF3-952A-EA41F9E5BF1E@gmail.com>
 <CAApHDvoQKY8zHb1LZBuYZBRszi0qVmTaV_zFup=A9xqRpJWMRQ@mail.gmail.com>
 <pse3eru75b5skbvc7jjrf7origavqojc6nqtwdrr7z6sjkyxfo@siklvj643v4f>
 <BB69B882-5401-45CE-919E-8A78511EDABC@gmail.com>
 <CAApHDvogTSD_G1nkJqOvO3gZFACQUCbKg6U7yBB48r5RMaR7-Q@mail.gmail.com>
 <CAApHDvrJBXEhet4=Es_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Wed, 17 Jun 2026 17:04:43 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <998004.1781676661.1@sss.pgh.pa.us>
Date: Wed, 17 Jun 2026 02:11:01 -0400
Message-ID: <998005.1781676661@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/998005.1781676661%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
>> 2. I can't quite figure out the pattern in these tests for dropping vs
>> not dropping the tables at the end of the test. Many tests do DROP
>> TABLE and a large number of others don't bother. What's meant to be
>> happening here?

> I added the DROP TABLE too, as I didn't see any reason mentioned
> anywhere that they should be kept.

A very rough rule of thumb is that we leave tables around if they
might be interesting for the pg_upgrade tests (which try to upgrade
the ending state of the core regression tests).

			regards, tom lane