Message-ID: <9996abbd-2a69-d838-3fc0-626ab783bcf6@gmail.com>
Date: Wed, 26 Apr 2023 13:13:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl
Content-Language: en-US
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <2fefa454-5a70-2174-ddbf-4a0e41537139@gmail.com>
 <CALDaNm2raNJrEF_ucDeTV_AygYutVb1bz2SrKO06YdVVG1gf2A@mail.gmail.com>
 <9ab1827c-9a57-8c48-59b2-c5fb62c21be3@gmail.com>
 <CAA4eK1KVoAjzT49BwKCih0A+1PE7hm=4PwQ-_VUr9YteFJRB5g@mail.gmail.com>
 <b6b6d59f-92ee-7a2c-8da3-366e59b96b7b@gmail.com>
 <CAA4eK1+7Mu6WYPj_+3kRWp2jj_ykrxxkheT3W3oc_G1hfWcaBw@mail.gmail.com>
 <8679d9c4-961b-b77f-baa7-718e58f953ff@gmail.com>
 <CALDaNm3ZGA-cxoq8O+VgBaRQ=s5JcKfaTPwVaAD4+htZa_uMEw@mail.gmail.com>
 <4ec4a071-8f0a-5536-58d5-cb815ef0905f@gmail.com>
 <CALDaNm0ABs4R=Qf8_D=ffUA=1mQT=o3ZxFrLecCE1Qgthyn8vw@mail.gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: 
 <CALDaNm0ABs4R=Qf8_D=ffUA=1mQT=o3ZxFrLecCE1Qgthyn8vw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/9996abbd-2a69-d838-3fc0-626ab783bcf6%40gmail.com>
Precedence: bulk

Hi,

On 4/26/23 11:12 AM, vignesh C wrote:
> On Wed, 26 Apr 2023 at 13:45, Drouvot, Bertrand
> 
> There was one typo in the commit message, subscribtion should be
> subscription, the rest of the changes looks good to me:
> Subject: [PATCH v5] Add subscribtion to the standby test in
>   035_standby_logical_decoding.pl
> 
> Adding one test, to verify that subscribtion to the standby is possible.
> 

Oops, at least I repeated it twice ;-)
Fixed in V6 that I just shared up-thread.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com