From: Ian Barwick <ian.barwick@2ndquadrant.com>
Subject: Re: Improving connection scalability: GetSnapshotData()
To: Andres Freund <andres@anarazel.de>, andrew@dunslane.net
Cc: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
 Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Daniel Gustafsson <daniel@yesql.se>, "Jonathan S. Katz"
 <jkatz@postgresql.org>, Alexander Korotkov <a.korotkov@postgrespro.ru>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
 David Rowley <dgrowleyml@gmail.com>
References: <20200816205258.pjvmoljrk7ntqb3n@alap3.anarazel.de>
 <20200816211146.nodohy6ck6mzfjwi@alap3.anarazel.de>
 <20200816212657.3vyijoddr2yvgjjc@alap3.anarazel.de>
 <20200903081554.GB8559@paquier.xyz>
 <61291ffe-d611-f889-68b5-c298da9fb18f@2ndquadrant.com>
 <20200908041114.5woxns33iv765fgh@alap3.anarazel.de>
 <0006ffe6-6f76-c074-3e58-2801cee1c05f@2ndquadrant.com>
 <d5f14b0e-58d2-56ab-0938-ab57ecc89d77@2ndquadrant.com>
 <20200914231718.gg7v77fx7nvvprjy@alap3.anarazel.de>
 <20200930224317.xuvsoptjg6b2ydxx@alap3.anarazel.de>
 <20201001182630.7kh2tiubf2lp3tzt@alap3.anarazel.de>
Message-ID: <99cc07c2-6eb2-b93e-858c-d9291a346155@2ndquadrant.com>
Date: Fri, 2 Oct 2020 11:14:19 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201001182630.7kh2tiubf2lp3tzt@alap3.anarazel.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020/10/02 3:26, Andres Freund wrote:
> Hi Ian, Andrew, All,
> 
> On 2020-09-30 15:43:17 -0700, Andres Freund wrote:
>> Attached is an updated version of the test (better utility function,
>> stricter regexes, bailing out instead of failing just the current when
>> psql times out).  I'm leaving it in this test for now, but it's fairly
>> easy to use this way, in my opinion, so it may be worth moving to
>> PostgresNode at some point.
> 
> I pushed this yesterday. Ian, thanks again for finding this and helping
> with fixing & testing.

Thanks! Apologies for not getting back to your earlier responses,
have been distracted by Various Other Things.

The tests I run which originally triggered the issue now run just fine.


Regards

Ian Barwick


-- 
Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services