Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqz5e-0000PS-9d for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Nov 2022 15:58:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oqz5c-0001iA-RI for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Nov 2022 15:58:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqz5c-0001gt-Ff for pgsql-hackers@lists.postgresql.org; Fri, 04 Nov 2022 15:58:40 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oqz5Z-0002Za-EG for pgsql-hackers@lists.postgresql.org; Fri, 04 Nov 2022 15:58:39 +0000 Received: by mail-pf1-x433.google.com with SMTP id v28so4861047pfi.12 for ; Fri, 04 Nov 2022 08:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timescale.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b81dfx0xNlxNkTUM8hdhJWrKVzy4KLIO8efsxG0TlZA=; b=F+oVeyxNwo8lPF8h1cZP1eTGwXC7njm5zPmm4e++OANVD1/KBtMPxurcDxhvSmXphC 1FDIbq850L888w8xOKtYqEfMd8Mk2BdP+RewGjaBAL1W4KzS6IkAtGPtv3JRNH8e+lL4 mJob/v7HO9pTzek5e6hUsdoB4mEnaOY0YDeNvCREOHh0VSH6+NG14WBgaM0iMcOb4x96 8ahi/tcUGUyPj86TTx2FUTfui74VhwdrgdNGM3lAXvoHAyKarmTNg9pcvFksmLhKAUmR RJ0Xzjrlk0sBQcz454sEtoYo5AFkNXnxfg80FyaHF8r+pzjW/2F0QzdhXq4tSdZYCSTG Hxgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b81dfx0xNlxNkTUM8hdhJWrKVzy4KLIO8efsxG0TlZA=; b=sEFB9967scUkA9G3Zsvz6fnPYd8Hk2OAI6TyaEXhndjT97jCYDuPROq9E62sMkyCmK UoWU8zzgLgXZvEevBv/vq6iya40qukE1n5fw41ZZrvOzE8lgESfGXk72O/zE/q2Okk7Z HHTd+a3AEwF7ZGmLtVSRkSyv4D/RPqEkCMa0o9QTPtUbqVi/MlYCy8y76o8lwKPKD/UM aXJBMkZ7Xd4c0rbUKbSbEYDIt9aH+EcT26jypXIKbW1tjQH284gvqN+j1iGVdCkZ3Nir lHfRD4KXyoR3FOXlK/fCoJkqQRsaqCcti+lWHjRC7wet/cjTdPZ86v+wDFd16s7hYG1L zjYg== X-Gm-Message-State: ACrzQf2zj2RJEhUoRE62JDzogTG6BV5EuhiAoQnMCQh5I/xjQADDgiS7 akg2V59E6GzR0/2Dh92SUknfBA== X-Google-Smtp-Source: AMsMyM5Wzm2CzR8TphpcrnJH5aezGtulUoaAAopXZFJikdVgHe3OLItsdm6t9SCdn1IYPjxZUjweig== X-Received: by 2002:a05:6a00:16c4:b0:535:890:d52 with SMTP id l4-20020a056a0016c400b0053508900d52mr36234125pfc.9.1667577516056; Fri, 04 Nov 2022 08:58:36 -0700 (PDT) Received: from [192.168.1.21] ([50.126.126.51]) by smtp.gmail.com with ESMTPSA id i15-20020a17090332cf00b00186cd4a8aedsm2797278plr.252.2022.11.04.08.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 08:58:35 -0700 (PDT) Message-ID: <99e3d1c5-4dd7-70f1-a520-89288a3496c2@timescale.com> Date: Fri, 4 Nov 2022 08:58:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Add non-blocking version of PQcancel Content-Language: en-US To: Jelte Fennema , Tom Lane Cc: Andres Freund , Justin Pryzby , Robert Haas , "pgsql-hackers@lists.postgresql.org" References: <20220324224909.4tnubqv2owmfoyoc@alap3.anarazel.de> <3453535.1648234019@sss.pgh.pa.us> <3457746.1648236890@sss.pgh.pa.us> <20220331054704.GL28503@telsasoft.com> <20220625013617.e4qvy6qlaukgvfpo@alap3.anarazel.de> <2906785.1663192411@sss.pgh.pa.us> From: Jacob Champion In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 10/5/22 06:23, Jelte Fennema wrote: > In my first version of this patch, this is exactly what I did. But then > I got this feedback from Jacob, so I changed it to reusing PGconn: > >> [snip] > > I changed it back to use PGcancelConn as per your suggestion and I > agree that the API got better because of it. Sorry for the whiplash! Is the latest attachment the correct version? I don't see any difference between the latest 0001 and the previous version's 0002 -- it has no references to PG_TEST_TIMEOUT_DEFAULT, PGcancelConn, etc. Thanks, --Jacob