Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJpKu-004HSy-2j for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 08:39:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vJpKr-005DhU-0H for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 08:39:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJpKq-005DhM-2S for pgsql-hackers@lists.postgresql.org; Fri, 14 Nov 2025 08:39:12 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vJpKn-007gUm-35 for pgsql-hackers@lists.postgresql.org; Fri, 14 Nov 2025 08:39:12 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-8b1b8264c86so170492585a.1 for ; Fri, 14 Nov 2025 00:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763109548; x=1763714348; darn=lists.postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zd9n0DVWy5ngnBVHNNkK9n03tYCOqc/8dASs9MprbPk=; b=M/TGg8a2KrTZOPy0miyRAku7IeYRakecwMPlZrdcmJAic8jDnWW9tid0wRj+QKQVKA KuLb9x1B0CWtpwXbNQFqdOiqIFS+D2e3mVSq5MzpqsA/Em2o6FN4qBfNbsFBVUjR/cf9 9p0TGjSRwp4v388pxbBBkVCf7pH/4oPuC4jNvQSXq95LLnuBaP7wJ3TNt+YuNrnV6JKt TsMDbqfiVrFULZHjmB26B/eLQICxbRugRvEeS6OeH+Fyy+AeI/9cF5haS6HskCDC6CGX 8JdegT+0nGRgmTJnLO6gBzjgecIBE86svdbSvyRo3bU1T1vvFEdg8nNXg7KIqxrFKpmM 6Avw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763109548; x=1763714348; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zd9n0DVWy5ngnBVHNNkK9n03tYCOqc/8dASs9MprbPk=; b=WStaW1z+soApa3NvlVqoJPZant8UMxUu0G79DqqAb1yFV5bbtADFnLkVLAOxrJYPj2 mGyGiEOX5Vax7qPq2iUqj+PIRg2AdYn25cT9SFGejNT8pOtQXNNNMLlLlWKifjXjbEnV SqMM6rzohS4Ker8eBCD387GUszKsiJuR+msvqS0ly4j8cpjsDagtR6BJnvrLXPMQPFKP /lLTzdUIvWNwfGbE0kNRFydvmg3eJn+CDiHSBZhWg1QzJ+9huDxHC1lFXcjwEvr8WhVo I2SmIMA9dNUtlY9coMjrR769fl8BfD3SW+DLyXVjF2/86rST8AvvsSFJ9VjUk1GLjVll 3j4A== X-Forwarded-Encrypted: i=1; AJvYcCVIL1Oj0WSE3iU3U3eYPphGg0X6Y64WqqOXE1PNKIl0zPEaTa3hMz+XhRWBvOFpZToGR44L0+zv/v8sPCx0@lists.postgresql.org X-Gm-Message-State: AOJu0YxZ0fJCGqwphghFfCTpiyXJbbHRK/dfMSn0gUH/3Z9yBeYPj6tY fsDyRegL4s5xNNpiSNz1qb+ST55bqheiF6oiiFCBiZhk/zdPUxAY0o+e X-Gm-Gg: ASbGnct/zzjXFugdCvqWKYCMCaJo1nbiRHQs4yQFlG93TLZwAGNS78it3CehXIsHXNs fk5FYBMheQTLzecZar/W9jrRyvT/r5TL6/BoyXjkhrZoTtbWwLiKXnzloaY0JyO5dz1yetKTRDV mfZYQtMv2/SiRlWbVsGOMtGgMqrHq9XXzqthHzfe+zqtETfrvI/QB7yo0qyAgKYecX9ivKTS5Hb 1lfeR/IOaa6PLO7N4/8gDm3dUODP7NaIfMonh2rhKHEys2oVBP8naGzcb4aRTGHyL4ux70MhtMc BwrjsxHJRer7PEP1VP3//+GIY/JZoo9o+GBUJY9Lm1UsGZYctIfGc4WT/iFxZodX9Atyn4t99bV 923s3I7DlMMZYeU48brE5aCkBhwjRMnawM924nA1+mtOYj5lVGmPuJQn7uma7FV271jAJlqJxZM GOCXmrEIGtQg== X-Google-Smtp-Source: AGHT+IHWiUOJ2VR7TDhV+BrCTVTbyDgeF6Nzs3Vk7gQGVLvxXMgkClVJJSL5OVY8NoH/r6CHuNnbFQ== X-Received: by 2002:a05:620a:3710:b0:8b2:5969:87ee with SMTP id af79cd13be357-8b2c3145587mr319332585a.5.1763109547879; Fri, 14 Nov 2025 00:39:07 -0800 (PST) Received: from smtpclient.apple ([209.127.78.222]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2af041dcbsm294051085a.45.2025.11.14.00.39.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2025 00:39:07 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: SQL:2011 Application Time Update & Delete From: Chao Li In-Reply-To: <6F8D7105-BD1C-432D-84F3-BC688C0C8EDC@gmail.com> Date: Fri, 14 Nov 2025 16:38:31 +0800 Cc: Peter Eisentraut , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <9B820A52-D2F6-465D-B258-6FE8EBA59FAE@gmail.com> References: <2f5364f3-a1d3-4410-98f3-d788b11e6525@eisentraut.org> <1ace7bc1-9dd4-42c9-a473-517cef37cce9@eisentraut.org> <6F8D7105-BD1C-432D-84F3-BC688C0C8EDC@gmail.com> To: Paul A Jungwirth X-Mailer: Apple Mail (2.3826.700.81) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Nov 14, 2025, at 12:10, Chao Li wrote: >=20 > 21 - 0008 - ri_triggers.c > ``` > + quoteOneName(attname, > + RIAttName(fk_rel, riinfo->fk_attnums[i])); > ``` >=20 > This patch uses quoteOneName() a lot. This function simply add double = quotes without much checks which is unsafe. I think quote_identifier() = is more preferred. I looked further, and realized that quoteOneName() is widely used in = ri_triggers.c and the dest string are all defined as size of = MAX_QUOTED_REL_NAME_LEN. So I take back comment 21. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/