Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2byv-0007a3-VB for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Aug 2020 15:02:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k2bys-0005Xc-QF for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Aug 2020 15:02:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2bys-0005XV-J7 for pgsql-hackers@lists.postgresql.org; Mon, 03 Aug 2020 15:02:26 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k2byp-0002mX-Kn for pgsql-hackers@postgresql.org; Mon, 03 Aug 2020 15:02:25 +0000 Received: by mail-pl1-x644.google.com with SMTP id bh1so7693488plb.12 for ; Mon, 03 Aug 2020 08:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H5WAVBo39Tz+oUfoJUfOMgCaUTohe8YbK1Lik0G1qwA=; b=xkIHVbquoNpIDKYt21zwE0QPP/OFA9em2DkSVDiGHz5bxzVYgcne8ktntcOfL15Sz1 QLMpfraGf/uMD5MCLSknFoxWcohyJKWNmpSCbbegrQbpAo9uQP0MgF2Vc1cPM2fr863w +fdxdf1YPJgflba4ChqSjESJsA5FLoFVCkYy/hWzKejTPyMY4GNqhul4qyXYSWOi73aY MSX5qXE5HEoURu71CNhlwOmF/7L+A6m2gsPPRJh5R7XhdeT3ukvhwHSQeafX9Rbhw+Kh I/dFLebXVHYW36KKO/izb7r7LVS1Vq1WbHX400zwENyXX+6aOVKEXw4gDcxEGARjFQXW Yq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H5WAVBo39Tz+oUfoJUfOMgCaUTohe8YbK1Lik0G1qwA=; b=WMEfTUct/sfb+UAJ+FgTOixVGFKgZ0Hqy7klANb6JsT90aPtFjU8JwqCltO5x6iglZ ZwG2MHqOstgvuUXY60iuKJ3ht9pf5oLrkYnN0mbdfYEUGVEfhtJhzvdUuVohKcvgONk8 BJ+hN5b1NMKDVSkreg2rhnRerga6oqIH6VfQp4d2l5i1zXOQXj1KLXoSNUusuJNvwhS7 JbJpulL42bXVn67qnpdTsXWhBbx/Dnfqgv5BjDcTebrzkjSyQvd8/nauk+KZN5iuJ//1 nwFk4ozOw9WNHShHhSPNKiS6RfcZqv7+1DHeHo+RmrbSLkHOry2/iKBQSZjUibNY5XEE oAFg== X-Gm-Message-State: AOAM532Cow8zDzogKWCYj9oxXUY7f5WcbfRBypuzfnPxFhXZFoVmCrHs a+fLggkw/KSxezcz6EViFcvOGFQ2G9ZseIds4fKDoPO/xIS/J/M3cFVwSIWB6X05OEh6ohKhbKt 41hGS+TOVq/ywZmQ6yS+K29B2q9bIBUlyWJakQHv7wQst7pxuVoFLAzSaTxTJwzaaex1wm74iAc SXWIiIBkKqB6xILbg7I+kjDyeCb0+IsNtawqSD X-Google-Smtp-Source: ABdhPJx1VfSV7k1ne8xtzxVxY7C2sODoa8chwm+4dxx68H/Nd4SE929aUqEhqkh1d+j4R74ja3fX8g== X-Received: by 2002:a17:90a:fa92:: with SMTP id cu18mr17149974pjb.215.1596466941483; Mon, 03 Aug 2020 08:02:21 -0700 (PDT) Received: from [192.168.0.29] (24-113-193-150.wavecable.com. [24.113.193.150]) by smtp.gmail.com with ESMTPSA id y128sm6244903pfy.74.2020.08.03.08.02.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2020 08:02:20 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: new heapcheck contrib module From: Mark Dilger In-Reply-To: Date: Mon, 3 Aug 2020 08:02:19 -0700 Cc: Robert Haas , Amul Sul , Dilip Kumar , Andres Freund , PostgreSQL-development Content-Transfer-Encoding: quoted-printable Message-Id: <9BE0DA14-0B5A-41DB-A613-2FDF72E98318@enterprisedb.com> References: <12ED3DA8-25F0-4B68-937D-D907CFBF08E7@enterprisedb.com> <20200420194210.sevnpi4lyghoanxi@alap3.anarazel.de> <23E60C3C-C20A-4508-84AC-E0CEA59E784A@enterprisedb.com> <5F743835-3399-419C-8324-2D424237E999@enterprisedb.com> <885D2EC9-7D06-4903-A17D-72C184A1E1C5@enterprisedb.com> <5CC85F28-F210-47AC-8DA8-EC4E82AF3FD5@enterprisedb.com> <0C0349EB-DD85-4DA8-82C7-DF70AB714592@enterprisedb.com> <9DF93B83-FE46-4EC4-A99D-77A60729FD2D@enterprisedb.com> To: Peter Geoghegan X-Mailer: Apple Mail (2.3608.80.23.2.2) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > On Aug 2, 2020, at 9:13 PM, Peter Geoghegan wrote: >=20 > On Thu, Jul 30, 2020 at 10:59 AM Robert Haas = wrote: >> I don't really like the name, either. I get that it's probably >> inspired by Perl, but I think it should be given a less-clever name >> like report_corruption() or something. >=20 > +1 -- confess() is an awful name for this. I was trying to limit unnecessary whitespace changes. = s/ereport/econfess/ leaves the function name nearly the same length such = that the following lines of indented error text don't usually get moved = by pgindent. Given the unpopularity of the name, it's not worth it, so = I'll go with Robert's report_corruption, instead. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company