Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvCIO-0007Gg-KF for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Jun 2021 05:16:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lvCIN-0007Tx-Hz for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Jun 2021 05:16:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvCIN-0007Ti-Af for pgsql-hackers@lists.postgresql.org; Mon, 21 Jun 2021 05:16:27 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lvCIK-0005ZD-On for pgsql-hackers@lists.postgresql.org; Mon, 21 Jun 2021 05:16:25 +0000 Received: by mail-pl1-x62d.google.com with SMTP id 69so7880091plc.5 for ; Sun, 20 Jun 2021 22:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=NJq668L49IWx+x28C0ng/6l/tDiaMK1VpoLoH6yjR8U=; b=HGWW+IWxS8ujfjTXHoP5obj9xpm9Fm78bP48ARUxcfZsPPIJHydEZ8ub63FhmY2rDT mlaSbFvMIEvgIPE1fuLSXf/29at44qILuWhuTmHcZBnghJIIDH3RCODeDyBpGq72Wt8h 41s6G4P23yyXodK6NqysnHr5Rwhf87yeHOD6PL93YwRe+/6P7KTonSox6vYabOKgl6Vb JbXy6I/8Z6jqoBwJtjSXABYJfGmwdfijjPrDokySwTDU5ame2hulo4ofD2YkrMu9mHi4 V+KqAxo6YetJBXR3vrTggd+LcV/QGKin7vx28RZIrldaCOwLXdGimuTeOZSpG5J3FJQo /n7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=NJq668L49IWx+x28C0ng/6l/tDiaMK1VpoLoH6yjR8U=; b=SYclSVAlIgw7YvbMwy16hrwgNVF4ucmbu4AhTpi+9HbO9mWy710D5k19Vp/9kKsG2M in+Cg9qADS88ufYjwYsDcIwcvgAFJUdQHSU3N2fHSZRNEvcKsfFnM0ZdXKHaVWpK1CM0 M4zZ2nR8NHrbBheduxxUb+uEWnqorkmFshtW/vHp1nCpYacGmMLENoGQThL6ITTN8HsK tDu60fgGTnSGgrONoKxZzZNTKVnN2QQybAGPeqFCMVH4G9LwD3SxGXoWNxPLYZCEp5LP 6XHnaFsjVQEeHImQRFFsB8eqMvgBHCUQWPmNon9YjutYOaH+DswM4wtrzEahzGSnjQDd XeNA== X-Gm-Message-State: AOAM531qJX6DmcDWXGXrIa/Ounu9nKCnhyFPAKrpfW+vvFS0S7HA37Ck 2dWjmQHJXtZ4JUxtK9p78TQ56c4v33L43hslaWlqosY2dBlJxI4xrRRrGiVoVs2hmuil7W3L4sr dwFs5ED53O9yAm3POGvr68NB5QVg1akat3gqOIJ1mtmPBiavdOnLuGcmig03T3vrzp0cNWURpl9 /dsgrwQDoK2kgMY+ZgoiaoYo1TiRA7ML1t/pookwCiOv1c7e6xDmbD X-Google-Smtp-Source: ABdhPJwFqbeZdUAKitVH3eT9qfXp+V2zYmxk7tYpBd01UYmtzJCZyCb5YxZwGKCCFOD+rK8ad6KLlg== X-Received: by 2002:a17:90a:414e:: with SMTP id m14mr23536652pjg.66.1624252583733; Sun, 20 Jun 2021 22:16:23 -0700 (PDT) Received: from ?IPv6:2600:6c50:157f:eb87:312a:3853:88ca:1561? ([2600:6c50:157f:eb87:312a:3853:88ca:1561]) by smtp.gmail.com with ESMTPSA id t13sm1460621pfq.4.2021.06.20.22.16.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jun 2021 22:16:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.6\)) Subject: Re: Optionally automatically disable logical replication subscriptions on error From: Mark Dilger In-Reply-To: Date: Sun, 20 Jun 2021 22:16:21 -0700 Cc: Masahiko Sawada , "Smith, Peter" , PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <9C995CB1-F4FD-4F66-B9B0-23E585234C73@enterprisedb.com> References: <14738A39-8000-463E-A0BA-6729930A32DA@enterprisedb.com> To: Amit Kapila X-Mailer: Apple Mail (2.3608.120.23.2.6) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Jun 20, 2021, at 10:11 PM, Amit Kapila = wrote: >=20 > Then also it will fail on the first such conflict, so even without > your patch, the apply worker corresponding to the subscription won't > be able to proceed after the first error, it won't lead to multiple > failing xids.=20 I'm not sure we're talking about the same thing. I'm saying that if the = user is expected to clear each error manually, there could be many such = errors for them to clear. It may be true that the second error doesn't = occur on the subscriber side until after the first is cleared, but that = still leaves the user having to clear one after the next until = arbitrarily many of them coming from the publisher side are cleared. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company