Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Fix pgstat_database.c to honor passed database OIDs
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <adw13WY5N5xp-YVi@paquier.xyz>
Date: Mon, 13 Apr 2026 08:43:53 +0800
Cc: Dapeng Wang <wangdp20191008@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: 7bit
Message-Id: <9D34D3BC-9F52-489E-98BE-6CB595710446@gmail.com>
References: <ABBD5026-506F-4006-A569-28F72C188693@gmail.com>
 <adiU2YZ0auyO6jie@paquier.xyz> <aditMVNDceHtvYj4@paquier.xyz>
 <8CD3DF77-C4F0-4CA0-B329-2B62B5A85E3B@gmail.com>
 <CAKx0YhzpuMkVwxa-fh36YOk11KZ6tjXnApAF=H6Sgso5a+P4Zg@mail.gmail.com>
 <adw13WY5N5xp-YVi@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/9D34D3BC-9F52-489E-98BE-6CB595710446%40gmail.com>
Precedence: bulk


> On Apr 13, 2026, at 08:16, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Fri, Apr 10, 2026 at 09:01:32PM +0800, Dapeng Wang wrote:
>> Without the patch, calling
>> pg_stat_reset_single_table_counters('pg_shdescription'::regclass)
>> incorrectly updates the current database's stats_reset timestamp
>> while leaving the shared db entry (datid=0) unchanged.
>> 
>> With the patch, the shared db entry's stats_reset is correctly
>> updated, and the current database's timestamp is not affected.
> 
> The coalesce() trick to bypass the fact that the reset timestamp may
> not be reset was a bit ugly, so I have used instead a second reset.
> I have limited the test to check for datid=0, not MyDatabaseId.
> 
> There is a bit down in stats.sql an extra portion of the test where we
> use twice pg_stats_reset().  One reset could be removed, but I have
> left it as-is in case someone decides to shuffle or split things in
> this test script, to avoid problems in the future.
> 
> And fixed that down to v15.
> --
> Michael

Thank you very much for fixing the test and pushing the patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/