Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Separators in pg_hosts.conf fields
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20260426213252.7a@rfd.leadboat.com>
Date: Sun, 26 Apr 2026 23:40:13 +0200
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9E767D01-08A1-4DF1-8122-B11AD932C8BA@yesql.se>
References: <20260426213252.7a@rfd.leadboat.com>
To: Noah Misch <noah@leadboat.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9E767D01-08A1-4DF1-8122-B11AD932C8BA%40yesql.se>
Precedence: bulk

> On 26 Apr 2026, at 23:32, Noah Misch <noah@leadboat.com> wrote:
>=20
> If the build directory name contains a comma,
> src/test/modules/ssl_passphrase_callback fails on master since commit =
4f43302.
> It fails because hba.c:next_token() treats a comma as a token =
separator:

Ugh, thanks for reporting.

> * Tokens can be delimited by double quotes (this allows the inclusion =
of
> * commas, blanks, and '#', but not newlines).  As in SQL, write two
> * double-quotes to represent a double quote.
>=20
> Commit 4f43302 documented the pg_hosts.conf hostname field as a
> comma-separated list, but not the other fields.  Should other =
pg_hosts.conf
> fields continue to require quoting around commas, or not?

Yes, only the hostname field is a comma-separated list.  I think this =
should be
added to the documentation as well on top of the test fix in your patch. =
 Do
you want me to take care of both parts?

--
Daniel Gustafsson