Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
From: Florents Tselai <florents.tselai@gmail.com>
In-Reply-To: 
 <CA+Tgmoae0B0ax=ScZyziW7xm6f3v3ciNNZiZW0gZBqZnm2AHUQ@mail.gmail.com>
Date: Thu, 22 May 2025 19:38:02 +0300
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 "David E. Wheeler" <david@justatheory.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9E77459B-0E6D-4105-A8D9-E5AED5F0AC0B@gmail.com>
References: 
 <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
 <145894.1727298237@sss.pgh.pa.us>
 <CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
 <CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
 <CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
 <88A95900-E976-43BE-A73A-45AA75A11EE7@justatheory.com>
 <3682F2FE-AB57-4799-A439-7DA518E978A4@gmail.com>
 <F4AB5396-ACCA-4358-969E-6708C7F6A95A@justatheory.com>
 <CA+Tgmoa-9tN85bEHfH7TBHa5uV1TwmZJEh_eYkLnwxOV=i6RSg@mail.gmail.com>
 <6A995806-5B9C-455C-8923-53A0448893BF@justatheory.com>
 <1303509.1747852287@sss.pgh.pa.us>
 <CA+Tgmoae0B0ax=ScZyziW7xm6f3v3ciNNZiZW0gZBqZnm2AHUQ@mail.gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9E77459B-0E6D-4105-A8D9-E5AED5F0AC0B%40gmail.com>
Precedence: bulk


> On 22 May 2025, at 5:05=E2=80=AFPM, Robert Haas =
<robertmhaas@gmail.com> wrote:
>=20
> On Wed, May 21, 2025 at 2:31=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> =
wrote:
>> Having said that, what's wrong with inventing some improved function
>> names and never removing the old ones?
>=20
> I don't particularly like the clutter, but if the consensus is that
> the clutter doesn't matter, fair enough.
>=20

It depends really on how much future work we expect in adding more =
methods in jsonpath.
I think there=E2=80=99s a lot of potential there, but that=E2=80=99s a =
guess really.

On David=E2=80=99s point about popularity:=20
In my experience timestamp related stuff from jsonb documents end up in =
a generated column,
and are indexed & queried there.
I expect that to continue in PG18 onwards as we=E2=80=99ll have virtual =
gen columns too.

Just to be clear, though, adding another version of these functions =
means
we=E2=80=99ll have an additional (now third) set of the same 5 =
functions:

The vanilla versions are considered stable and the suffixed *_tz or =
*_volatile (?)=20

jsonb_path_exists
jsonb_path_query
jsonb_path_query_array
jsonb_path_query_first
jsonb_path_match