Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_62521FC4-D3E2-429E-9668-CD9E89DF472B";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\))
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: <278cb771-6008-44e5-8eaa-9d4acdb56c79@dunslane.net>
Date: Sat, 28 Mar 2026 10:30:42 -0400
Cc: Florents Tselai <florents.tselai@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Chao Li <li.evan.chao@gmail.com>,
 =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 jian he <jian.universality@gmail.com>
Message-Id: <9E9B3C10-7535-4704-A04A-DF5D32C43DBE@justatheory.com>
References: <202510210803.3b3vfvygxtjl@alvherre.pgsql>
 <87530674-E6B6-4C97-A704-78C7E07CF01F@gmail.com>
 <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
 <CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
 <A654130B-16AF-4E37-9D73-B3CDC80C751C@justatheory.com>
 <CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
 <CACJufxGdgxyRLd03wM=GtJzUskXnXxEBGGtwA2vsTvkV827SxA@mail.gmail.com>
 <CACJufxHxWKhNcTsmYz428yxUikeUVZz=o6mLNRXpB7F_1oDEng@mail.gmail.com>
 <CECA8C06-755C-4550-88C8-0E1E0CB03D64@justatheory.com>
 <DB26FD47-DF09-4A92-AA15-08F012ED0DE2@justatheory.com>
 <CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>
 <931F201B-FF38-486E-BDEE-DF9692A01E1D@justatheory.com>
 <D81098C5-CB6D-47BE-995B-A451BE396525@justatheory.com>
 <1eb15091-660d-477b-acda-b61d00bc9ffb@dunslane.net>
 <278cb771-6008-44e5-8eaa-9d4acdb56c79@dunslane.net>
To: Andrew Dunstan <andrew@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/9E9B3C10-7535-4704-A04A-DF5D32C43DBE%40justatheory.com>
Precedence: bulk


--Apple-Mail=_62521FC4-D3E2-429E-9668-CD9E89DF472B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Mar 28, 2026, at 06:04, Andrew Dunstan <andrew@dunslane.net> wrote:

> I have fixed that. Some key_name entries were missing, which was an =
issue. I also removed some unused variables and some duplicate tests, =
and did some general tidying.

Looks good to me! I=E2=80=99m curious what the implication of missing =
`key_name`s was, since the tests passed and all the functions worked. =
Can we create additional tests that would fail when the keys were =
missing?

D


--Apple-Mail=_62521FC4-D3E2-429E-9668-CD9E89DF472B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmnH5hIACgkQkt9idPjI
gfEHOA//TdQiVXFF/CfTcadagPkggkF8gHF13VlSULt/gMzDkbM1cUsgrYPXJV62
QyfGILS0M6NPz0jwkInJcDVQvlNZ0ik58EuOU/6qi6+rmh0/ta0c3Ftoa1JoTJfF
Gbu6t7GwMwZ4cAvd5YfTEKsonYTdZ/MJX3JrfRy4ShX3mqEJ9v7t9N97yNyuHfAF
dyE8+7xTZ1xRcJgwoOV/Myt/amuZZ/ggQzZ1n2dT9/KrAMBdTx+96sVRMYg1HYmj
+gNJrV3+/22nLRa2KlgWc5zWsoOM0OxH5nSYYacO6SPi7dAguJbZJ2N5fYHg87WW
no3tnh87jFUjQG80IpiXkgdMq0mTY/sQRatEKCT8xT5lxSw1Ghore96fw8XmpOjS
2FZIjdvu1lbIiJformiWfnSsMJb4Pdnvx7UabJuhn4WB1Az6FY6z7nCqNuDSoQVN
674PweQcjykNa6Slqsfz85WeO9P7O3uL5iztrBgEIcDphn5L4VcVNpOaZIsK3aKy
B2cOLiFRgV18oPdyXf20XxdEitj3QxPxjP/bpTZUXG87Nb5xvv12lur/e0d5coWs
rrgHhVzTbiok3YiAzi/dZOL6NxAq98cL8h0jcrCZV8GUMOblY7xtoSR8JgnyhorW
Yg7CaPvWx0OVO2ZXBVeATM0mB6jCQrnyGjsRLitN//oJLcQDGNg=
=DPpY
-----END PGP SIGNATURE-----

--Apple-Mail=_62521FC4-D3E2-429E-9668-CD9E89DF472B--