Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: remove obsolete comment in AtEOXact_Inval
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com>
Date: Mon, 27 Oct 2025 11:50:21 +0800
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9ED67E9F-9735-4033-AF27-31A674DE75C8@gmail.com>
References: 
 <MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com>
To: Steven Niu <niushiji@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9ED67E9F-9735-4033-AF27-31A674DE75C8%40gmail.com>
Precedence: bulk


> On Oct 27, 2025, at 10:43, Steven Niu <niushiji@gmail.com> wrote:
>=20
> Hi, Hackers,
>=20
> When I read the code, I noticed there is one line of comment in =
function AtEOXact_Inval() which is obviously obsolete.
>=20
>     "This should be called as the last step in processing a =
transaction" =20
>=20
> Steven<0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch>

+1

The comment of "void AtEOXact_Inval(bool isCommit):
```
 * Note:
* This should be called as the last step in processing a transaction.
```
Was added 29 years ago.

However, looking at CommitTransaction():

```
    /*
* Make catalog changes visible to all backends. This has to happen after
* relcache references are dropped (see comments for
* AtEOXact_RelationCache), but before locks are released (if anyone is
* waiting for lock on a relation we've modified, we want them to know
* about the catalog change before they start using the relation).
*/
AtEOXact_Inval(true);

AtEOXact_MultiXact(); # <=3D=3D=3D added 21 years ago
```

it seems the newer change has made the original comment inaccurate.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/