Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Add missing period to HINT messages
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
Date: Thu, 9 Apr 2026 10:09:09 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318@gmail.com>
References: 
 <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318%40gmail.com>
Precedence: bulk


> On Apr 9, 2026, at 07:30, Peter Smith <smithpb2250@gmail.com> wrote:
>=20
> Hi,
>=20
> According to the error message style guide [1], "Detail and hint
> messages: Use complete sentences, and end each with a period."
>=20
> I found there is a small group of HINT messages not following that =
period rule.
>=20
> PSA a patch that fixes the missing period. In passing, also fixed a
> typo in a hint message /msut/must/.
>=20
> ~~~
>=20
> On further inspection, lots of these affected messages don't even seem
> grammatically correct to me.
>=20
> I did not modify them, but here are examples of what I mean.
>=20
> e.g.
> "ALTER TABLE ... MERGE PARTITIONS can only merge partitions don't have
> sub-partitions."
> /don't have/that don't have/
>=20
> e.g.
> "ALTER TABLE ... SPLIT PARTITION can only split partitions don't have
> sub-partitions."
> /don't have/that don't have/
>=20
> e.g.
> "To split DEFAULT partition one of the new partition must be DEFAULT."
> missing word? -- "To split the DEFAULT partition"
> should be plural? -- "one of the new partitions"
>=20
> e.g.
> "%s require combined bounds of new partitions must exactly match the
> bound of the split partition."
> /require/requires/ ?
> /match the bound/match the bounds/
>=20
> =3D=3D=3D=3D=3D=3D
> [1] =
https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-G=
UIDE-GRAMMAR-PUNCTUATION
>=20
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
> <v1-0001-Add-missing-period-to-HINT-messages.patch>

LGTM.

BTW, errdetail should follow the same style, and I see some detail =
messages miss periods, maybe this patch can include those as well.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/