Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vfEoM-000640-2W
	for pgsql-hackers@arkaria.postgresql.org;
	Mon, 12 Jan 2026 10:06:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vfEoL-0004iU-32
	for pgsql-hackers@arkaria.postgresql.org;
	Mon, 12 Jan 2026 10:06:10 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <rkhapov@yandex-team.ru>)
	id 1vfEoL-0004iM-1f
	for pgsql-hackers@lists.postgresql.org;
	Mon, 12 Jan 2026 10:06:09 +0000
Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <rkhapov@yandex-team.ru>)
	id 1vfEoH-0000jX-1E
	for pgsql-hackers@postgresql.org;
	Mon, 12 Jan 2026 10:06:09 +0000
Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:5c05:0:640:ff67:0])
	by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 45FEA806F5;
	Mon, 12 Jan 2026 13:06:04 +0300 (MSK)
Received: from smtpclient.apple (unknown [2a02:6bf:803e:e00:ad76:b1b2:a1d:8d79])
	by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id 36Peee3AteA0-OYnGfmuG;
	Mon, 12 Jan 2026 13:06:03 +0300
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;
	s=default; t=1768212363;
	bh=6XafgPlyYhN239+sNt+alLbarvEF/7qKsr55aSGiWNs=;
	h=Message-Id:To:Date:References:Cc:In-Reply-To:From:Subject;
	b=szRlOWikGDnen16LvnbFeXrL21IEnhkHk+VJlIHS1qHhkwfgTPwnrTggXJQje7pG2
	 sGL7AnNQ9AdH/0/PdDaQn1e2LhWZiSlCCftbn5oVwz8bbZgRFOS3/Pl1WidJmSyNmJ
	 IW2e1vQYYR/Kmc9akEYcRrf62bQXCAsJaHVncy7Y=
Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: Add ldapservice connection parameter
From: Roman Khapov <rkhapov@yandex-team.ru>
In-Reply-To: <CAKK5BkFOFGfKJNbTuYBvE0PfpHmW8iZEmdNogaCYqjAOhtNgDg@mail.gmail.com>
Date: Mon, 12 Jan 2026 15:05:53 +0500
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9FF1E1E8-D9EE-43C5-ADFA-7AE94BA57159@yandex-team.ru>
References: <CAKK5BkFOFGfKJNbTuYBvE0PfpHmW8iZEmdNogaCYqjAOhtNgDg@mail.gmail.com>
To: Andrew Jackson <andrewjackson947@gmail.com>
X-Mailer: Apple Mail (2.3864.300.41.1.7)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/9FF1E1E8-D9EE-43C5-ADFA-7AE94BA57159%40yandex-team.ru>
Precedence: bulk

Hi!

Thanks for your patch!

Adding to the one Steven wrote, I noticed one typo in the patch:

@@ -2337,7 +2337,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
       <term><literal>ldapservice</literal></term>
       <listitem>
        <para>
-        This option specifies an LDAP query that can be used to =
reference connection paremeters
+        This option specifies an LDAP query that can be used to =
reference connection parameters
         stored in an LDAP server. This functionality is described in =
more detail in <xref linkend=3D"libpq-ldap"/>.
         </para>

paremeters -> parameters

--
Best regards,
Roman Khapov=