Message-ID: <9a235a36d71a50bff5c14dc14df40f5b1e703e2e.camel@j-davis.com>
Subject: Re: [17] CREATE SUBSCRIPTION ... SERVER
From: Jeff Davis <pgsql@j-davis.com>
To: Joe Conway <mail@joeconway.com>, Ashutosh Bapat
	 <ashutosh.bapat.oss@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, 
	pgsql-hackers@postgresql.org
Date: Mon, 15 Jan 2024 13:34:18 -0800
In-Reply-To: <c7185435-eb8c-426d-beac-9aaa7e972d02@joeconway.com>
References: <149ff9264db27cdf724b65709fbbaee4bf316835.camel@j-davis.com>
	 <e531ec798298a21d671babd45849092850b8675e.camel@j-davis.com>
	 <ac4042d6-204c-9661-9949-79ab8a1f8604@joeconway.com>
	 <CAExHW5unvpDv6yMSmqurHP7Du1PqoJFWVxeK-4YNm5EnoNJiSQ@mail.gmail.com>
	 <433d0845248e86c0317d9d396926182cfe157340.camel@j-davis.com>
	 <CAExHW5sQVJeCgCGMkum_k4Z4VPaK5GkdAjHW-d+F3MngBZ9qBA@mail.gmail.com>
	 <05ae37abb207cd6bf6b126780024692d91402b0b.camel@j-davis.com>
	 <93392ffa941ab0d436e19e0ab5d04d0e42c02d3f.camel@j-davis.com>
	 <26be917cb07b6aa3ef5dd15f6b59d1b375ece6e8.camel@j-davis.com>
	 <CALj2ACXDua2Az15Kj3OZFaRm49G8-faemiEEv8t9GNCcsxv8Hw@mail.gmail.com>
	 <55201bd916e748acfc754c8f95880dae8e4e5ed0.camel@j-davis.com>
	 <CAExHW5v5poohyfNRVQp3yjVE56ej0dWvVMbysSSVtg21aHT3uQ@mail.gmail.com>
	 <e71e029309171eb8b6ca393306f9bc5acfbfdf8f.camel@j-davis.com>
	 <CAExHW5vF+cp9efQj=-W+Rhbr9f9ZZqt3XFnP0NB5jKsm=C=5tw@mail.gmail.com>
	 <2a89b14a2b1622bffb8b137ca1f9ab7866f2d2b9.camel@j-davis.com>
	 <c7185435-eb8c-426d-beac-9aaa7e972d02@joeconway.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/9a235a36d71a50bff5c14dc14df40f5b1e703e2e.camel%40j-davis.com>
Precedence: bulk

On Mon, 2024-01-15 at 15:53 -0500, Joe Conway wrote:
> I took a quick scan through the patch. The only thing that jumped out
> at=20
> me was that it seems like it might make sense to use=20
> quote_literal_cstr() rather than defining your own
> appendEscapedValue()=20
> function?

The rules are slightly different. Libpq expects a connection string to
escape only single-quote and backslash, and the escape character is
always backslash:

https://www.postgresql.org/docs/16/libpq-connect.html#LIBPQ-CONNSTRING-KEYW=
ORD-VALUE

quote_literal_cstr() has more complicated rules. If there's a backslash
anywhere in the string, it uses the E'' form. If it encounters a
backslash it escapes it with backslash, but if it encounters a single-
quote it escapes it with single-quote. See:

https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-STRIN=
GS
https://www.postgresql.org/docs/16/sql-syntax-lexical.html#SQL-SYNTAX-STRIN=
GS-ESCAPE

I'll include some tests and a better comment for it in the next patch
set.

Regards,
	Jeff Davis