Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qTxw1-00BFTk-Jc for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Aug 2023 05:10:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qTxvz-00BDL0-Tu for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Aug 2023 05:10:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qTxvz-00BDKp-Ja for pgsql-hackers@lists.postgresql.org; Thu, 10 Aug 2023 05:10:08 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qTxvv-001ciP-Tn for pgsql-hackers@lists.postgresql.org; Thu, 10 Aug 2023 05:10:07 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 334366120A; Thu, 10 Aug 2023 14:09:57 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_2ba1b8ebd308faaa792add4760496d06" Content-Transfer-Encoding: 8bit Date: Thu, 10 Aug 2023 14:09:57 +0900 From: Masahiro Ikeda To: pgsql-hackers@lists.postgresql.org Cc: mitsuru.hinata.5432@gmail.com Subject: Re: Fix pg_stat_reset_single_table_counters function In-Reply-To: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com> References: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <9a4a6718abb47647ae83f1f4b3f9bf68@oss.nttdata.com> X-Sender: ikedamsh@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_2ba1b8ebd308faaa792add4760496d06 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed On 2023-08-01 15:23, Masahiro Ikeda wrote: > Hi, > > My colleague, Mitsuru Hinata (in CC), found the following issue. > > The documentation of pg_stat_reset_single_table_counters() says >> pg_stat_reset_single_table_counters ( oid ) → void >> Resets statistics for a single table or index in the current database >> or shared across all databases in the cluster to zero. >> This function is restricted to superusers by default, but other users >> can be granted EXECUTE to run the function. > https://www.postgresql.org/docs/devel/monitoring-stats.html > > But, the stats will not be reset if the table shared across all > databases is specified. IIUC, 5891c7a8e seemed to have mistakenly > removed the feature implemented in e04267844. What do you think? I fix an issue with the v1 patch reported by cfbot. The test case didn't assume the number of databases will change in the test of pg_upgrade. Regards, -- Masahiro Ikeda NTT DATA CORPORATION --=_2ba1b8ebd308faaa792add4760496d06 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v2_0001-Fix-pg_stat_reset_single_table_counters-function.patch Content-Disposition: attachment; filename=v2_0001-Fix-pg_stat_reset_single_table_counters-function.patch; size=5913 RnJvbSAxODJjNjc2MzgwYWE5MWEzNTY4MTRkOGUzODdlNWU1ZmU3ZTJjM2MwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlybyBJa2VkYSA8bXNoci5pa2VkYUBudHQuY29tPgpE YXRlOiBUaHUsIDEwIEF1ZyAyMDIzIDEzOjQ2OjA5ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IHBnX3N0YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzIGZ1bmN0aW9uLgoKVGhpcyBjb21t aXQgcmV2aXZlcyB0aGUgZmVhdHVyZSB0byByZXNldCBzdGF0aXN0aWNzIGZvciBhIHNpbmdsZQpy ZWxhdGlvbiBzaGFyZWQgYWNyb3NzIGFsbCBkYXRhYmFzZXMgaW4gdGhlIGNsdXN0ZXIgdG8gemVy bywgd2hpY2gKd2FzIGltcGxlbWVudGVkIGJ5IHRoZSBmb2xsb3dpbmcgY29tbWl0LgoqIEVuaGFu Y2UgcGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMgZnVuY3Rpb24oZTA0MjY3ODQ0 KQoKVGhlIGZvbGxvd2luZyBjb21taXQgYWNjaWRlbnRhbGx5IGRlbGV0ZWQgdGhlIGZlYXR1cmUu CiogcGdzdGF0OiBzdG9yZSBzdGF0aXN0aWNzIGluIHNoYXJlZCBtZW1vcnkoNTg5MWM3YThlKQoK QnVtcCBjYXRhbG9nIHZlcnNpb24uCgpOZWVkIHRvIGJhY2twYXRjaCBmcm9tIDE1LgoKUmVwb3J0 ZWQtYnk6IE1pdHN1cnUgSGluYXRhCi0tLQogc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3Bnc3RhdGZ1 bmNzLmMgfCAgOSArKysrLQogc3JjL2luY2x1ZGUvY2F0YWxvZy9jYXR2ZXJzaW9uLmggICAgfCAg MiArLQogc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQgfCA2MCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKwogc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsICAgICAg fCAxOCArKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdzdGF0ZnVuY3Mu YyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCmluZGV4IDJhNGM4ZWY4N2Yu LjJiOTc0MmFkMjEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5j cy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCkBAIC0xNyw2ICsx Nyw3IEBACiAjaW5jbHVkZSAiYWNjZXNzL2h0dXBfZGV0YWlscy5oIgogI2luY2x1ZGUgImFjY2Vz cy94bG9nLmgiCiAjaW5jbHVkZSAiYWNjZXNzL3hsb2dwcmVmZXRjaGVyLmgiCisjaW5jbHVkZSAi Y2F0YWxvZy9jYXRhbG9nLmgiCiAjaW5jbHVkZSAiY2F0YWxvZy9wZ19hdXRoaWQuaCIKICNpbmNs dWRlICJjYXRhbG9nL3BnX3R5cGUuaCIKICNpbmNsdWRlICJjb21tb24vaXAuaCIKQEAgLTE3NzYs MTMgKzE3NzcsMTcgQEAgcGdfc3RhdF9yZXNldF9zaGFyZWQoUEdfRlVOQ1RJT05fQVJHUykKIAlQ R19SRVRVUk5fVk9JRCgpOwogfQogCi0vKiBSZXNldCBhIHNpbmdsZSBjb3VudGVyIGluIHRoZSBj dXJyZW50IGRhdGFiYXNlICovCisvKgorICogUmVzZXQgYSBzdGF0aXN0aWNzIGZvciBhIHNpbmds ZSBvYmplY3QsIHdoaWNoIG1heSBiZSBvZiBjdXJyZW50CisgKiBkYXRhYmFzZSBvciBzaGFyZWQg YWNyb3NzIGFsbCBkYXRhYmFzZXMgaW4gdGhlIGNsdXN0ZXIuCisgKi8KIERhdHVtCiBwZ19zdGF0 X3Jlc2V0X3NpbmdsZV90YWJsZV9jb3VudGVycyhQR19GVU5DVElPTl9BUkdTKQogewogCU9pZAkJ CXRhYm9pZCA9IFBHX0dFVEFSR19PSUQoMCk7CisJT2lkCQkJZGJvaWQgPSAoSXNTaGFyZWRSZWxh dGlvbih0YWJvaWQpID8gSW52YWxpZE9pZCA6IE15RGF0YWJhc2VJZCk7CiAKLQlwZ3N0YXRfcmVz ZXQoUEdTVEFUX0tJTkRfUkVMQVRJT04sIE15RGF0YWJhc2VJZCwgdGFib2lkKTsKKwlwZ3N0YXRf cmVzZXQoUEdTVEFUX0tJTkRfUkVMQVRJT04sIGRib2lkLCB0YWJvaWQpOwogCiAJUEdfUkVUVVJO X1ZPSUQoKTsKIH0KZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2NhdGFsb2cvY2F0dmVyc2lvbi5o IGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9jYXR2ZXJzaW9uLmgKaW5kZXggZjUwN2I0OWJiMi4uN2Qy MGM1OGIxZCAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvY2F0YWxvZy9jYXR2ZXJzaW9uLmgKKysr IGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9jYXR2ZXJzaW9uLmgKQEAgLTU3LDYgKzU3LDYgQEAKICAq LwogCiAvKgkJCQkJCQl5eXl5bW1kZE4gKi8KLSNkZWZpbmUgQ0FUQUxPR19WRVJTSU9OX05PCTIw MjMwNzI2MQorI2RlZmluZSBDQVRBTE9HX1ZFUlNJT05fTk8JMjAyMzA4MTAxCiAKICNlbmRpZgpk aWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQgYi9zcmMvdGVz dC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dAppbmRleCAzMTkxNjRhNWU5Li4yNDhlMDcyMzk1 IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dAorKysgYi9z cmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dApAQCAtNTkyLDYgKzU5Miw2NiBAQCBT RUxFQ1Qgc2VxX3NjYW4sIGlkeF9zY2FuIEZST00gcGdfc3RhdF9hbGxfdGFibGVzIFdIRVJFIHJl bGlkID0gJ3Rlc3RfbGFzdF9zY2FuJwogICAgICAgICAwIHwgICAgICAgIDAKICgxIHJvdykKIAor LS0gZW5zdXJlIHRvIHJlc2V0IHN0YXRpc3RpY3MgZm9yIGEgdGFibGUgYW5kIGEgaW5kZXggc2hh cmVkIGFjcm9zcyBhbGwgZGF0YWJhc2VzCitCRUdJTjsKK1NFVCBMT0NBTCBlbmFibGVfc2Vxc2Nh biBUTyBvbjsKK1NFVCBMT0NBTCBlbmFibGVfaW5kZXhzY2FuIFRPIG9mZjsKK1NFVCBMT0NBTCBl bmFibGVfaW5kZXhvbmx5c2NhbiBUTyBvZmY7CitFWFBMQUlOIChDT1NUUyBvZmYpIFNFTEVDVCBj b3VudCgqKSA+PSAwIEZST00gcGdfZGF0YWJhc2U7CisgICAgICAgICAgUVVFUlkgUExBTiAgICAg ICAgICAgCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisgQWdncmVnYXRlCisgICAt PiAgU2VxIFNjYW4gb24gcGdfZGF0YWJhc2UKKygyIHJvd3MpCisKK1NFTEVDVCBjb3VudCgqKSA+ PSAwIEZST00gcGdfZGF0YWJhc2U7IC0tIGluY3JlbWVudCBzdGF0cyBmb3IgdGhlIHRhYmxlCisg P2NvbHVtbj8gCistLS0tLS0tLS0tCisgdAorKDEgcm93KQorCitTRVQgTE9DQUwgZW5hYmxlX3Nl cXNjYW4gVE8gb2ZmOworU0VUIExPQ0FMIGVuYWJsZV9pbmRleHNjYW4gVE8gb247CitTRVQgTE9D QUwgZW5hYmxlX2luZGV4b25seXNjYW4gVE8gb2ZmOworRVhQTEFJTiAoQ09TVFMgb2ZmKSBTRUxF Q1QgY291bnQoKikgPj0gMCBGUk9NIHBnX2RhdGFiYXNlIFdIRVJFIG9pZCA9IDE7CisgICAgICAg ICAgICAgICAgICAgICAgICAgUVVFUlkgUExBTiAgICAgICAgICAgICAgICAgICAgICAgICAgCist LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCisgQWdncmVnYXRlCisgICAtPiAgSW5kZXggU2NhbiB1c2luZyBwZ19kYXRhYmFzZV9vaWRf aW5kZXggb24gcGdfZGF0YWJhc2UKKyAgICAgICAgIEluZGV4IENvbmQ6IChvaWQgPSAnMSc6Om9p ZCkKKygzIHJvd3MpCisKK1NFTEVDVCBjb3VudCgqKSA+PSAwIEZST00gcGdfZGF0YWJhc2UgV0hF UkUgb2lkID0gMTsgLS0gaW5jcmVtZW50IHN0YXRzIGZvciB0aGUgaW5kZXgKKyA/Y29sdW1uPyAK Ky0tLS0tLS0tLS0KKyB0CisoMSByb3cpCisKK0NPTU1JVDsKK1NFTEVDVCBwZ19zdGF0X3Jlc2V0 X3NpbmdsZV90YWJsZV9jb3VudGVycygncGdfZGF0YWJhc2UnOjpyZWdjbGFzcyk7CisgcGdfc3Rh dF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMgCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCisgCisoMSByb3cpCisKK1NFTEVDVCBwZ19zdGF0X3Jlc2V0X3NpbmdsZV90 YWJsZV9jb3VudGVycygncGdfZGF0YWJhc2Vfb2lkX2luZGV4Jzo6cmVnY2xhc3MpOworIHBnX3N0 YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQorIAorKDEgcm93KQorCitTRUxFQ1QgcGdfc3RhdF9yZXNldF9zaW5nbGVf dGFibGVfY291bnRlcnMoJ3BnX2RhdGFiYXNlX2RhdG5hbWVfaW5kZXgnOjpyZWdjbGFzcyk7Cisg cGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMgCistLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCisgCisoMSByb3cpCisKK1NFTEVDVCBzZXFfc2NhbiwgaWR4X3Nj YW4gRlJPTSBwZ19zdGF0X2FsbF90YWJsZXMgV0hFUkUgcmVsaWQgPSAncGdfZGF0YWJhc2UnOjpy ZWdjbGFzczsKKyBzZXFfc2NhbiB8IGlkeF9zY2FuIAorLS0tLS0tLS0tLSstLS0tLS0tLS0tCisg ICAgICAgIDAgfCAgICAgICAgMAorKDEgcm93KQorCiAtLSBlbnN1cmUgd2Ugc3RhcnQgb3V0IHdp dGggZXhhY3RseSBvbmUgaW5kZXggYW5kIHNlcXVlbnRpYWwgc2NhbgogQkVHSU47CiBTRVQgTE9D QUwgZW5hYmxlX3NlcXNjYW4gVE8gb247CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL3Nx bC9zdGF0cy5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9zdGF0cy5zcWwKaW5kZXggOWExNmRm MWM0OS4uODQ4MmI2NWZhZiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMu c3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbApAQCAtMzA5LDYgKzMwOSwy NCBAQCBDT01NSVQ7CiBTRUxFQ1QgcGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMo J3Rlc3RfbGFzdF9zY2FuJzo6cmVnY2xhc3MpOwogU0VMRUNUIHNlcV9zY2FuLCBpZHhfc2NhbiBG Uk9NIHBnX3N0YXRfYWxsX3RhYmxlcyBXSEVSRSByZWxpZCA9ICd0ZXN0X2xhc3Rfc2Nhbic6OnJl Z2NsYXNzOwogCistLSBlbnN1cmUgdG8gcmVzZXQgc3RhdGlzdGljcyBmb3IgYSB0YWJsZSBhbmQg YSBpbmRleCBzaGFyZWQgYWNyb3NzIGFsbCBkYXRhYmFzZXMKK0JFR0lOOworU0VUIExPQ0FMIGVu YWJsZV9zZXFzY2FuIFRPIG9uOworU0VUIExPQ0FMIGVuYWJsZV9pbmRleHNjYW4gVE8gb2ZmOwor U0VUIExPQ0FMIGVuYWJsZV9pbmRleG9ubHlzY2FuIFRPIG9mZjsKK0VYUExBSU4gKENPU1RTIG9m ZikgU0VMRUNUIGNvdW50KCopID49IDAgRlJPTSBwZ19kYXRhYmFzZTsKK1NFTEVDVCBjb3VudCgq KSA+PSAwIEZST00gcGdfZGF0YWJhc2U7IC0tIGluY3JlbWVudCBzdGF0cyBmb3IgdGhlIHRhYmxl CitTRVQgTE9DQUwgZW5hYmxlX3NlcXNjYW4gVE8gb2ZmOworU0VUIExPQ0FMIGVuYWJsZV9pbmRl eHNjYW4gVE8gb247CitTRVQgTE9DQUwgZW5hYmxlX2luZGV4b25seXNjYW4gVE8gb2ZmOworRVhQ TEFJTiAoQ09TVFMgb2ZmKSBTRUxFQ1QgY291bnQoKikgPj0gMCBGUk9NIHBnX2RhdGFiYXNlIFdI RVJFIG9pZCA9IDE7CitTRUxFQ1QgY291bnQoKikgPj0gMCBGUk9NIHBnX2RhdGFiYXNlIFdIRVJF IG9pZCA9IDE7IC0tIGluY3JlbWVudCBzdGF0cyBmb3IgdGhlIGluZGV4CitDT01NSVQ7CitTRUxF Q1QgcGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMoJ3BnX2RhdGFiYXNlJzo6cmVn Y2xhc3MpOworU0VMRUNUIHBnX3N0YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzKCdwZ19k YXRhYmFzZV9vaWRfaW5kZXgnOjpyZWdjbGFzcyk7CitTRUxFQ1QgcGdfc3RhdF9yZXNldF9zaW5n bGVfdGFibGVfY291bnRlcnMoJ3BnX2RhdGFiYXNlX2RhdG5hbWVfaW5kZXgnOjpyZWdjbGFzcyk7 CitTRUxFQ1Qgc2VxX3NjYW4sIGlkeF9zY2FuIEZST00gcGdfc3RhdF9hbGxfdGFibGVzIFdIRVJF IHJlbGlkID0gJ3BnX2RhdGFiYXNlJzo6cmVnY2xhc3M7CisKIC0tIGVuc3VyZSB3ZSBzdGFydCBv dXQgd2l0aCBleGFjdGx5IG9uZSBpbmRleCBhbmQgc2VxdWVudGlhbCBzY2FuCiBCRUdJTjsKIFNF VCBMT0NBTCBlbmFibGVfc2Vxc2NhbiBUTyBvbjsKLS0gCjIuMjUuMQoK --=_2ba1b8ebd308faaa792add4760496d06--