Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5Xyt-0002Tq-Fo for pgsql-hackers@arkaria.postgresql.org; Tue, 02 May 2017 13:36:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d5Xyt-0003FP-2Z for pgsql-hackers@arkaria.postgresql.org; Tue, 02 May 2017 13:36:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d5XxN-0000Yi-Jg for pgsql-hackers@postgresql.org; Tue, 02 May 2017 13:35:09 +0000 Received: from lists.commandprompt.com ([2604:da00:2:2:5054:ff:fe07:7618]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d5XxE-0005tE-TU for pgsql-hackers@postgresql.org; Tue, 02 May 2017 13:35:08 +0000 Received: from [192.168.1.61] (spinlock.commandprompt.com [69.168.55.30]) by lists.commandprompt.com (Postfix) with ESMTPA id 5B2AE13C; Tue, 2 May 2017 06:34:56 -0700 (PDT) Received: from c-73-225-27-179.hsd1.wa.comcast.net ([73.225.27.179] helo=[192.168.1.61]) by assp.commandprompt.com with SMTPSA(TLSv1_2 ECDHE-RSA-AES128-GCM-SHA256) (2.5.1); 2 May 2017 06:34:55 -0700 Subject: Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) To: Tom Lane , Robert Haas References: <27478.1493727233@sss.pgh.pa.us> Cc: Petr Jelinek , Michael Paquier , PostgreSQL mailing lists From: "Joshua D. Drake" Organization: Command Prompt, Inc. Message-ID: <9a581750-5687-76b0-78d0-5a79c8bfc6f5@commandprompt.com> Date: Tue, 2 May 2017 06:34:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <27478.1493727233@sss.pgh.pa.us> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Assp-Version: 2.5.1(16177) on assp.commandprompt.com X-Assp-ID: assp.commandprompt.com m1-32096-09682 X-Assp-Session: 7F28DC38CF98 (mail 1) X-Assp-Original-Subject: Re: [HACKERS] logical replication syntax (was DROP SUBSCRIPTION,query cancellations and slot handling) X-Assp-Client-SSL: yes X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/02/2017 05:13 AM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Apr 20, 2017 at 7:46 AM, Petr Jelinek >> wrote: >>> DROP SUBSCRIPTION mysub NODROP SLOT; > Having said that, I doubt that anyone would argue that CREATE USER is > anything but legacy syntax, or that our more recent syntax designs aren't > better models to follow. > > It's not quite too late to revisit the syntax of the log rep commands > ... shall we add this as an open item? I would think so. Just in reading this, even if we keep a similar syntax it should be DROP SLOT NO or DROP SLOT FALSE. JD > > regards, tom lane > > -- Command Prompt, Inc. http://the.postgres.company/ +1-503-667-4564 PostgreSQL Centered full stack support, consulting and development. Everyone appreciates your honesty, until you are honest with them. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers