Message-ID: <9a762503-79c9-e7aa-191a-9bfa0d77cc38@oss.nttdata.com>
Date: Thu, 7 Jul 2022 01:11:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, michael@paquier.xyz
Cc: bharath.rupireddyforpostgres@gmail.com, nathandbossart@gmail.com,
 sfrost@snowman.net, bossartn@amazon.com, rjuju123@gmail.com,
 pgsql-hackers@lists.postgresql.org
References: <20220315.172340.1059971522574284501.horikyota.ntt@gmail.com>
 <YjBbwiZSRsGzgbcW@paquier.xyz>
 <20220316.091913.806120467943749797.horikyota.ntt@gmail.com>
 <20220316.102947.378283819592596734.horikyota.ntt@gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20220316.102947.378283819592596734.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/9a762503-79c9-e7aa-191a-9bfa0d77cc38%40oss.nttdata.com>
Precedence: bulk


On 2022/03/16 10:29, Kyotaro Horiguchi wrote:
> At Wed, 16 Mar 2022 09:19:13 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
>> In short, I split out the two topics other than checkpoint log to
>> other threads.
> 
> So, this is about the main topic of this thread, adding LSNs to
> checkpint log.  Other topics have moved to other treads [1], [2] ,
> [3].
> 
> I think this is no longer controversial alone.  So this patch is now
> really Read-for-Commiter and is waiting to be picked up.

+1

+						 * ControlFileLock is not required as we are the only
+						 * updator of these variables.

Isn't it better to add "at this time" or something at the end of the comment because only we're not always updator of them? No?

Barring any objection, I'm thinking to apply the above small change and commit the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION