Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7eHj-005Ykg-2O for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 18:57:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7eHi-00CfOn-0r for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Mar 2026 18:57:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7eHh-00CfOf-2m for pgsql-hackers@lists.postgresql.org; Tue, 31 Mar 2026 18:57:54 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w7eHf-00000002Dov-39hp for pgsql-hackers@postgresql.org; Tue, 31 Mar 2026 18:57:54 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id A6D1A5C5F4F for ; Tue, 31 Mar 2026 20:57:49 +0200 (CEST) Received: from s981.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 986045C6131; Tue, 31 Mar 2026 20:57:49 +0200 (CEST) Received: from localhost (unknown [172.22.191.5]) by s981.loopia.se (Postfix) with ESMTP id 95DEE22B17A8; Tue, 31 Mar 2026 20:57:49 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s898.loopia.se (amavis); dkim=pass (2048-bit key) header.d=proxel.se Received: from s979.loopia.se ([172.22.191.6]) by localhost (s898.loopia.se [172.22.190.17]) (amavis, port 10024) with LMTP id Z6N9MRHFf7aD; Tue, 31 Mar 2026 20:57:49 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s979.loopia.se (Postfix) with ESMTPSA id EAFFC10BC3A3; Tue, 31 Mar 2026 20:57:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1774983469; bh=Xcpem3ojt2HffDpduQb2cAu39EZcCyy4xWvM7iapcRg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=owAVMVWRd9yVwmWJHpaDwKKp7vYotpj8tGYBffVdUf36q0R8opKTzCX9qUo/doJ8i zdMchVyI5llBrnootoYBFrn6DAUoXJI1x2uDu5/4WBWWFEk+38WX7kHXplCm96/+Tn jDwT62VhLwFwgabbY2USprWqreBh8JYSkqZRLdXnQ/JrSqGJ+92mEKQWuNdO3uA4Nq omMsjSDCwa3Paglex5nKkDLxCikMDL5HX4KXd8kADp7vrIp6eiA0d75hRTdxnVTonK Y2TpEji7/rQYG+Bp8vLfutZw71Aod5O4DXVZ3oPRQ3h/8Iz/1UPgXaM0FzganGtJGB 3T8NM1FyO0P8w== Message-ID: <9a949301-eb31-4245-aef5-6ced20716ec4@proxel.se> Date: Tue, 31 Mar 2026 20:57:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Improve pgindent's formatting named fields in struct literals and varidic functions To: Tom Lane , =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: Jelte Fennema-Nio , pgsql-hackers References: <202603311716.cribie6xvxhn@alvherre.pgsql> <2737243.1774980800@sss.pgh.pa.us> From: Andreas Karlsson Content-Language: en-US In-Reply-To: <2737243.1774980800@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/31/26 8:13 PM, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera writes: >> I think the best time to get it in is a few weeks after the feature >> freeze. That way we minimize the impact on any fixes during the >> stabilization period. I'm not sure at what point relative to the betas >> though; is it better to do it before, so that we have a chance to fix >> any possible problems before they hit users, or is it better to do after >> beta1, so that patches that we discover need reverting for pg19 have >> already had a chance to be so? > > [...] > > So we haven't been totally consistent about it, but mid-May (a couple > weeks before making the new branch) seems like the usual choice. Makes sense to merge it while the tree is less noisy. Especially right now might be the most annoying time possible. Andreas