MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 17 Mar 2023 21:23:14 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Daniel Gustafsson <daniel@yesql.se>, Damir Belyalov
 <dam.bel07@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andres Freund
 <andres@anarazel.de>, Danil Anisimow <anisimow.d@gmail.com>, Nikita Malakhov
 <HukuToc@gmail.com>, a.lepikhov@postgrespro.ru, tgl@sss.pgh.pa.us
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
In-Reply-To: <F2BEB24D-A6AB-4BB1-AC75-9A060E5338E0@yesql.se>
References: <CALH1Lgv5QeYSWYDgMBd=wvKum8egiaMR-_77VGsiHPt7E8dK9Q@mail.gmail.com>
 <CALH1LgvzpORM+EHVXRz4-Dv+_aHvm9m9Hu6eYM4PfppwKgXvFQ@mail.gmail.com>
 <686e46d6718f9535bc39fac7cad7408b@oss.nttdata.com>
 <CALH1Lgsr7Asz6r6jnRta7DVEjKwyz=b3XJhyCMoYv8Yy9y4cXg@mail.gmail.com>
 <769423519e16d18a1e7611c6931da58b@oss.nttdata.com>
 <CALH1LguQ5P0uZSYQFy4gJihvV11EkLx+gwxZ-+1DFq1Z6dJqbg@mail.gmail.com>
 <CALH1Lgug+mR9A1bBzR8hrp2oW4=jvR_N0An-i2X_j_y9C1fkiA@mail.gmail.com>
 <CALH1LguPAN=p5wHKwGcHrjE8Vj1x4o1z3Pk228YDif6LFzbeYQ@mail.gmail.com>
 <CABm2Ma6_=qf7kZPyOmiK1CUXeio7q08HNPYXrqkCwF3P_KQu7A@mail.gmail.com>
 <CALH1Lgv+L_HNN2NKo=WD8BbgLy7tEH7=OhNTJ2QWCU_CPMum0g@mail.gmail.com>
 <20230205233723.xw5z5zmeyc57ezq3@alap3.anarazel.de>
 <CALH1LgsbWZWS3qMxdGjg4n57DUHxqyBgTzvYSzfi-sP1N-ZORQ@mail.gmail.com>
 <2587470.1675660337@sss.pgh.pa.us>
 <483E1B59-4A80-450B-8685-7CC12762FD5A@anarazel.de>
 <2592557.1675663234@sss.pgh.pa.us>
 <39143e83571d59dfc04c75707fa0ea5a@oss.nttdata.com>
 <CALH1LgvQ5eRMi3zO7RSmod4ucru=9ekASpReahR7zDcCabANZw@mail.gmail.com>
 <0DE0602F-CC12-40ED-B259-3AB91FB02C3B@yesql.se>
 <8ad8492ff9fae3481d87c7aab4e0aed0@oss.nttdata.com>
 <CALH1LguAEsoTYJTCsXNB-7z2Hu9UGEpsXA4kj0FOTmoP=6Wp3Q@mail.gmail.com>
 <F2BEB24D-A6AB-4BB1-AC75-9A060E5338E0@yesql.se>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <9a94e684d6528dff74de5959e97032f3@oss.nttdata.com>
Archived-At: <https://www.postgresql.org/message-id/9a94e684d6528dff74de5959e97032f3%40oss.nttdata.com>
Precedence: bulk

On 2023-03-07 18:09, Daniel Gustafsson wrote:
>> On 7 Mar 2023, at 09:35, Damir Belyalov <dam.bel07@gmail.com> wrote:
> 
>> I felt just logging "Error: %ld" would make people wonder the meaning 
>> of
>> the %ld. Logging something like ""Error: %ld data type errors were
>> found" might be clearer.
>> 
>> Thanks. For more clearance change the message to: "Errors were found: 
>> %".
> 
> I'm not convinced that this adds enough clarity to assist the user.  We 
> also
> shouldn't use "error" in a WARNING log since the user has explicitly 
> asked to
> skip rows on error, so it's not an error per se.
+1

> How about something like:
> 
>   ereport(WARNING,
>           (errmsg("%ld rows were skipped due to data type
> incompatibility", cstate->ignored_errors),
>            errhint("Skipped rows can be inspected in the database log
> for reprocessing.")));
Since skipped rows cannot be inspected in the log when 
log_error_verbosity is set to terse,
it might be better without this errhint.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION