MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_c9683c51305f41c0471b43bc3e17c1bb"
Content-Transfer-Encoding: 7bit
Date: Thu, 31 Oct 2024 14:18:09 +0900
From: Yushi Ogiwara <btogiwarayuushi@oss.nttdata.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Fix for Extra Parenthesis in pgbench progress message
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <9a9b8b95b6a709877ae48ad5b0c59bb9@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9a9b8b95b6a709877ae48ad5b0c59bb9%40oss.nttdata.com>
Precedence: bulk

--=_c9683c51305f41c0471b43bc3e17c1bb
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Hi,

I noticed an issue in the pgbench progress message where an extra 
closing parenthesis )) appears, as shown below:

7000000 of 10000000 tuples (70%) of pgbench_accounts done (elapsed 19.75 
s, remaining 8.46 s))

This occurs when running commands like pgbench -i -s100 and is caused by 
leftover characters when using \r with fprintf. I made a patch to 
address this by adding extra spaces before \r, which clears any 
remaining characters. While effective, I recognize this solution may not 
be the most sophisticated.

A more refined solution, such as using string padding, might be ideal 
for cases like this.

Best,
Yushi Ogiwara
--=_c9683c51305f41c0471b43bc3e17c1bb
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=fix_leftover_character.diff
Content-Disposition: attachment;
 filename=fix_leftover_character.diff;
 size=1331

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMgYi9zcmMvYmluL3BnYmVuY2gv
cGdiZW5jaC5jCmluZGV4IGU2NThkMDYwYWQuLmJlOTg0ZTBjN2YgMTAwNjQ0Ci0tLSBhL3NyYy9i
aW4vcGdiZW5jaC9wZ2JlbmNoLmMKKysrIGIvc3JjL2Jpbi9wZ2JlbmNoL3BnYmVuY2guYwpAQCAt
NTAwNCw3ICs1MDA0LDcgQEAgaW5pdFBvcHVsYXRlVGFibGUoUEdjb25uICpjb24sIGNvbnN0IGNo
YXIgKnRhYmxlLCBpbnQ2NCBiYXNlLAogCQkJZG91YmxlCQllbGFwc2VkX3NlYyA9IFBHX1RJTUVf
R0VUX0RPVUJMRShwZ190aW1lX25vdygpIC0gc3RhcnQpOwogCQkJZG91YmxlCQlyZW1haW5pbmdf
c2VjID0gKChkb3VibGUpIHRvdGFsIC0gaikgKiBlbGFwc2VkX3NlYyAvIGo7CiAKLQkJCWNoYXJz
ID0gZnByaW50ZihzdGRlcnIsIElOVDY0X0ZPUk1BVCAiIG9mICIgSU5UNjRfRk9STUFUICIgdHVw
bGVzICglZCUlKSBvZiAlcyBkb25lIChlbGFwc2VkICUuMmYgcywgcmVtYWluaW5nICUuMmYgcykl
YyIsCisJCQljaGFycyA9IGZwcmludGYoc3RkZXJyLCBJTlQ2NF9GT1JNQVQgIiBvZiAiIElOVDY0
X0ZPUk1BVCAiIHR1cGxlcyAoJWQlJSkgb2YgJXMgZG9uZSAoZWxhcHNlZCAlLjJmIHMsIHJlbWFp
bmluZyAlLjJmIHMpICAgJWMiLAogCQkJCQkJCWosIHRvdGFsLAogCQkJCQkJCShpbnQpICgoaiAq
IDEwMCkgLyB0b3RhbCksCiAJCQkJCQkJdGFibGUsIGVsYXBzZWRfc2VjLCByZW1haW5pbmdfc2Vj
LCBlb2wpOwpAQCAtNTAxOCw3ICs1MDE4LDcgQEAgaW5pdFBvcHVsYXRlVGFibGUoUEdjb25uICpj
b24sIGNvbnN0IGNoYXIgKnRhYmxlLCBpbnQ2NCBiYXNlLAogCQkJLyogaGF2ZSB3ZSByZWFjaGVk
IHRoZSBuZXh0IGludGVydmFsIChvciBlbmQpPyAqLwogCQkJaWYgKChqID09IHRvdGFsKSB8fCAo
ZWxhcHNlZF9zZWMgPj0gbG9nX2ludGVydmFsICogTE9HX1NURVBfU0VDT05EUykpCiAJCQl7Ci0J
CQkJY2hhcnMgPSBmcHJpbnRmKHN0ZGVyciwgSU5UNjRfRk9STUFUICIgb2YgIiBJTlQ2NF9GT1JN
QVQgIiB0dXBsZXMgKCVkJSUpIG9mICVzIGRvbmUgKGVsYXBzZWQgJS4yZiBzLCByZW1haW5pbmcg
JS4yZiBzKSVjIiwKKwkJCQljaGFycyA9IGZwcmludGYoc3RkZXJyLCBJTlQ2NF9GT1JNQVQgIiBv
ZiAiIElOVDY0X0ZPUk1BVCAiIHR1cGxlcyAoJWQlJSkgb2YgJXMgZG9uZSAoZWxhcHNlZCAlLjJm
IHMsIHJlbWFpbmluZyAlLjJmIHMpICAgJWMiLAogCQkJCQkJCQlqLCB0b3RhbCwKIAkJCQkJCQkJ
KGludCkgKChqICogMTAwKSAvIHRvdGFsKSwKIAkJCQkJCQkJdGFibGUsIGVsYXBzZWRfc2VjLCBy
ZW1haW5pbmdfc2VjLCBlb2wpOwo=
--=_c9683c51305f41c0471b43bc3e17c1bb--