Content-Type: multipart/alternative;
	boundary="------------OMpKYrzhxJJrh9bJ3kd6NLKf"
Message-ID: <9aee54f2-5cc1-5b64-1f73-6961932e7bd2@amazon.com>
Date: Wed, 7 Sep 2022 18:19:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.0
Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements
To: "Drouvot, Bertrand" <bdrouvot@amazon.com>
CC: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Pavel Stehule
	<pavel.stehule@gmail.com>, Andres Freund <andres@anarazel.de>, "Imseih (AWS),
 Sami" <simseih@amazon.com>
References: <36e5bffe-e989-194f-85c8-06e7bc88e6f7@amazon.com>
 <20220831160839.wseeotr7rckucpmv@awork3.anarazel.de>
 <46ca04f9-1e37-c862-9a28-c5dffaee412f@amazon.com>
 <20220831190604.l2luuhj3xkau7dvk@awork3.anarazel.de>
 <e43a0e02-4ef4-d510-a00a-cf39d2a9df19@amazon.com>
 <cbd28368-a5ae-f141-4c3f-28ba9f608ba0@amazon.com>
 <BBB9A13D-BBE2-44A4-9CA7-6E189120E5A2@amazon.com>
 <09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com>
Content-Language: en-US
From: Jeremy Schneider <schnjere@amazon.com>
In-Reply-To: <09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9aee54f2-5cc1-5b64-1f73-6961932e7bd2%40amazon.com>
Precedence: bulk

--------------OMpKYrzhxJJrh9bJ3kd6NLKf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On 9/2/22 2:06 AM, Drouvot, Bertrand wrote:
> v3 including this change is attached.

FYI: "reset all" core dumps with v3

I didn't fully debug yet, but here's the backtrace on my 14.4 build with
the patch

[postgres@ip-172-31-44-176 data]$ gdb /usr/local/pgsql-14.4/bin/postgres
core.27217
...
Core was generated by `postgres: postgres postgres [local]
RESET                                '.
Program terminated with signal 11, Segmentation fault.
#0  0x00007f7776ae4821 in __strlen_sse2_pminub () from /lib64/libc.so.6
...
(gdb) bt
#0  0x00007f7776ae4821 in __strlen_sse2_pminub () from /lib64/libc.so.6
#1  0x00000000008e061c in JumbleExpr (jstate=0x1cf7f80, node=<optimized
out>) at queryjumble.c:400
#2  0x00000000008dfdd8 in JumbleQueryInternal (jstate=0x1cf7f80,
query=0x1cf7e70) at queryjumble.c:247
#3  0x00000000008e0b4b in JumbleQuery (query=query@entry=0x1cf7e70,
querytext=querytext@entry=0x1cf72f8 "reset all;") at queryjumble.c:127
#4  0x000000000056ba4b in parse_analyze (parseTree=0x1cf7ce0,
sourceText=0x1cf72f8 "reset all;", paramTypes=0x0, numParams=<optimized
out>, queryEnv=0x0) at analyze.c:130
#5  0x000000000079df63 in pg_analyze_and_rewrite
(parsetree=parsetree@entry=0x1cf7ce0,
query_string=query_string@entry=0x1cf72f8 "reset all;",
    paramTypes=paramTypes@entry=0x0, numParams=numParams@entry=0,
queryEnv=queryEnv@entry=0x0) at postgres.c:657
#6  0x000000000079e472 in exec_simple_query (query_string=0x1cf72f8
"reset all;") at postgres.c:1130
#7  0x000000000079f9d3 in PostgresMain (argc=argc@entry=1,
argv=argv@entry=0x7ffd0c341f80, dbname=0x1d44948 "postgres",
username=<optimized out>) at postgres.c:4496
#8  0x000000000048c9f3 in BackendRun (port=<optimized out>,
port=<optimized out>) at postmaster.c:4530
#9  BackendStartup (port=0x1d3bdd0) at postmaster.c:4252
#10 ServerLoop () at postmaster.c:1745
#11 0x0000000000721332 in PostmasterMain (argc=argc@entry=5,
argv=argv@entry=0x1cf1e10) at postmaster.c:1417
#12 0x000000000048da6e in main (argc=5, argv=0x1cf1e10) at main.c:209


-- 
Jeremy Schneider
Database Engineer
Amazon Web Services

--------------OMpKYrzhxJJrh9bJ3kd6NLKf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 9/2/22 2:06 AM, Drouvot, Bertrand
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      v3 including this change is attached.</blockquote>
    <br>
    FYI: "reset all" core dumps with v3<br>
    <br>
    I didn't fully debug yet, but here's the backtrace on my 14.4 build
    with the patch<br>
    <br>
    [postgres@ip-172-31-44-176 data]$ gdb
    /usr/local/pgsql-14.4/bin/postgres core.27217<br>
    ...<br>
    Core was generated by `postgres: postgres postgres [local]
    RESET                                '.<br>
    Program terminated with signal 11, Segmentation fault.<br>
    #0  0x00007f7776ae4821 in __strlen_sse2_pminub () from
    /lib64/libc.so.6<br>
    ...<br>
    (gdb) bt<br>
    #0  0x00007f7776ae4821 in __strlen_sse2_pminub () from
    /lib64/libc.so.6<br>
    #1  0x00000000008e061c in JumbleExpr (jstate=0x1cf7f80,
    node=&lt;optimized out&gt;) at queryjumble.c:400<br>
    #2  0x00000000008dfdd8 in JumbleQueryInternal (jstate=0x1cf7f80,
    query=0x1cf7e70) at queryjumble.c:247<br>
    #3  0x00000000008e0b4b in JumbleQuery (query=query@entry=0x1cf7e70,
    querytext=querytext@entry=0x1cf72f8 "reset all;") at
    queryjumble.c:127<br>
    #4  0x000000000056ba4b in parse_analyze (parseTree=0x1cf7ce0,
    sourceText=0x1cf72f8 "reset all;", paramTypes=0x0,
    numParams=&lt;optimized out&gt;, queryEnv=0x0) at analyze.c:130<br>
    #5  0x000000000079df63 in pg_analyze_and_rewrite
    (parsetree=parsetree@entry=0x1cf7ce0,
    query_string=query_string@entry=0x1cf72f8 "reset all;",<br>
        paramTypes=paramTypes@entry=0x0, numParams=numParams@entry=0,
    queryEnv=queryEnv@entry=0x0) at postgres.c:657<br>
    #6  0x000000000079e472 in exec_simple_query (query_string=0x1cf72f8
    "reset all;") at postgres.c:1130<br>
    #7  0x000000000079f9d3 in PostgresMain (argc=argc@entry=1,
    argv=argv@entry=0x7ffd0c341f80, dbname=0x1d44948 "postgres",
    username=&lt;optimized out&gt;) at postgres.c:4496<br>
    #8  0x000000000048c9f3 in BackendRun (port=&lt;optimized out&gt;,
    port=&lt;optimized out&gt;) at postmaster.c:4530<br>
    #9  BackendStartup (port=0x1d3bdd0) at postmaster.c:4252<br>
    #10 ServerLoop () at postmaster.c:1745<br>
    #11 0x0000000000721332 in PostmasterMain (argc=argc@entry=5,
    argv=argv@entry=0x1cf1e10) at postmaster.c:1417<br>
    #12 0x000000000048da6e in main (argc=5, argv=0x1cf1e10) at
    main.c:209<br>
    <br>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Jeremy Schneider
Database Engineer
Amazon Web Services</pre>
  </body>
</html>

--------------OMpKYrzhxJJrh9bJ3kd6NLKf--