Message-ID: <9af5e9e7-b5e8-c761-33d0-453c660e8fca@dunslane.net>
Date: Sun, 29 Oct 2023 10:22:27 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: run pgindent on a regular basis / scripted manner
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>, Jelte Fennema <postgres@jeltef.nl>,
 Michael Paquier <michael@paquier.xyz>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>,
 Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
 Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net>
 <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net>
 <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net>
 <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
 <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net>
 <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net>
 <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
 <ZEOfzsDrQ1SMOj4Q@paquier.xyz>
 <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net>
 <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
 <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net>
 <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net>
 <CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com>
 <343394.1691795823@sss.pgh.pa.us>
 <5a40cc37-3cae-b3c3-1435-04292cabf298@dunslane.net> <c51959af-d7e4-779!
 0-4979-329bcaf9849e@dunslane.net> <1831630.1698509355@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <1831630.1698509355@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/9af5e9e7-b5e8-c761-33d0-453c660e8fca%40dunslane.net>
Precedence: bulk


On 2023-10-28 Sa 12:09, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Based on recent experience, where a lot koel's recent complaints seem to
>> be about comments, I'd like to suggest a modest adjustment.
>> First, we should provide a mode of pgindent that doesn't reflow
>> comments. pg_bsd_indent has a flag for this (-nfcb), so this should be
>> relatively simple.  Second, koel could use that mode, so that it
>> wouldn't complain about comments it thinks need to be reflowed. Of
>> course, we'd fix these up with our regular pgindent runs.
> Seems like a bit of a kluge.  Maybe it's the right thing to do, but
> I don't think we have enough data points yet to be confident that
> it'd meaningfully reduce the number of breakages.
>
> On a more abstract level: the point of trying to maintain indent
> cleanliness is so that if you modify a file and then want to run
> pgindent on your own changes, you don't get incidental changes
> elsewhere in the file.  This solution would break that, so I'm
> not sure it isn't throwing the baby out with the bathwater.


Yeah, could be.


cheers


andrew.

--
Andrew Dunstan
EDB: https://www.enterprisedb.com