public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Andres Freund <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: meson: pkgconfig difference
Date: Wed, 1 Feb 2023 18:15:22 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 01.02.23 08:55, Andres Freund wrote:
> Hi,
> 
> On January 31, 2023 11:40:52 PM PST, Peter Eisentraut <[email protected]> wrote:
>> I think there is a tiny typo in src/interfaces/ecpg/ecpglib/meson.build:
>>
>> diff --git a/src/interfaces/ecpg/ecpglib/meson.build b/src/interfaces/ecpg/ecpglib/meson.build
>> index dba9e3c3d9..da8d304f54 100644
>> --- a/src/interfaces/ecpg/ecpglib/meson.build
>> +++ b/src/interfaces/ecpg/ecpglib/meson.build
>> @@ -57,7 +57,7 @@ pkgconfig.generate(
>>    description: 'PostgreSQL libecpg library',
>>    url: pg_url,
>>    libraries: ecpglib_so,
>> -  libraries_private: [frontend_shlib_code, thread_dep],
>> +  libraries_private: [frontend_stlib_code, thread_dep],
>>    requires_private: ['libpgtypes', 'libpq'],
>> )
>>
>> This makes it match the other libraries.
>>
>> Without this change, we get
>>
>> Libs.private: ... -lpgport_shlib -lpgcommon_shlib
>>
>> which seems wrong.
> 
> Ugh, yes, that's wrong. Do you want me to apply the fix?

I've done it now.

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: meson: pkgconfig difference
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox